Do not take ownership of key on get/delete

[kpcyrd]

I've noticed that on get and delete, the method takes ownership of they key. This is somewhat unexpected, since the value can be borrowed on put, but the key can't. This may require calling the library with key.clone(), which I'd like to avoid. :)

I've looked into the code, while I think it should be safe to change that to a borrow, I'd like to avoid touching the unsafe parts of the crate myself.

leveldb/src/database/kv.rs

Lines 96 to 126 in 118359e

	/// get a value from the database.
	///
	/// The passed key will be compared using the comparator.
	fn get<'a>(&self, options: ReadOptions<'a, K>, key: K) -> Result<Option<Vec<u8>>, Error> {
	unsafe {
	key.as_slice(|k| {
	let mut error = ptr::null_mut();
	let mut length: size_t = 0;
	let c_readoptions = c_readoptions(&options);
	let result = leveldb_get(self.database.ptr,
	c_readoptions,
	k.as_ptr() as *mut c_char,
	k.len() as size_t,
	&mut length,
	&mut error);
	leveldb_readoptions_destroy(c_readoptions);
	if error == ptr::null_mut() {
	if result == ptr::null_mut() {
	Ok(None)
	} else {
	let vec = from_raw_parts(result as *mut u8, length as usize).to_vec();
	leveldb_free(result as *mut c_void);
	Ok(Some(vec))
	}
	} else {
	Err(Error::new_from_i8(error))
	}
	})
	}
	}

Thanks!

[skade]

Hi @kpcyrd,

I'm not sure why this decision was made, I'll check that later.

Thanks for the report.

[skade]

See release 0.8.4.

Relevant commit: 1dbc8e3