Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): refactor button component #33

Merged
merged 1 commit into from
Sep 27, 2018
Merged

Conversation

PeterShershov
Copy link
Contributor

Refactored button component and updated tests.
div to button, em to rem.

@johanzilber @liorheber

@AmirAsaraf
Copy link
Collaborator

@PeterShershov why do you need the button implementation over a simple div? It causes misalignment with the dropbox (fonts and default button stuff)

@PeterShershov
Copy link
Contributor Author

PeterShershov commented Sep 26, 2018

I fixed the alignment by setting the font-size to be similar to the dropdown.
Changing the div to a button will help with semantics, accessibility, html attributes such as disabled will prevent onClick to trigger automatically... @AmirAsaraf

@johanzilber johanzilber merged commit ba6b462 into master Sep 27, 2018
@johanzilber johanzilber deleted the refactor-button branch September 27, 2018 06:03
@liorheber
Copy link
Collaborator

Well, button in Firefox has an added animation on click which will make it jitter.
You will need to align the styles between the browsers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants