cosmetic changes (#2)

* remove xt

* use warnings

* no autodie

* use XSLoader

* use Exporter

* remove broken link

* set Rob Hoelz as an author

* add t/00report.t

META.json

@@ -1,7 +1,7 @@
 {
    "abstract" : "Monitor a directory structure for changes",
    "author" : [
-      "Andy Grundman, <andy@hybridized.org>"
+      "Andy Grundman <andy@hybridized.org>, Rob Hoelz <rob@hoelz.ro>"
    ],
    "dynamic_config" : 0,
    "generated_by" : "Dist::Zilla version 6.030, CPAN::Meta::Converter version 2.150010",
@@ -26,8 +26,7 @@
       },
       "test" : {
          "requires" : {
-            "Test::More" : "0.99",
-            "autodie" : "0"
+            "Test::More" : "0.99"
          }
       }
    },
@@ -56,7 +55,6 @@
    "x_contributors" : [
       "Doug Bell <madcityzen@gmail.com>",
       "Fayland Lam <fayland@gmail.com>",
-      "Rob Hoelz <rob@hoelz.ro>",
       "Shoichi Kaji <skaji@cpan.org>"
    ],
    "x_generated_by_perl" : "v5.38.0",

Makefile.PL

@@ -55,7 +55,7 @@ my %args = (
 
 my %WriteMakefileArgs = (
   "ABSTRACT" => "Monitor a directory structure for changes",
-  "AUTHOR" => "Andy Grundman, <andy\@hybridized.org>",
+  "AUTHOR" => "Andy Grundman <andy\@hybridized.org>, Rob Hoelz <rob\@hoelz.ro>",
   "CONFIGURE_REQUIRES" => {
     "ExtUtils::MakeMaker" => 0
   },
@@ -65,8 +65,7 @@ my %WriteMakefileArgs = (
   "NAME" => "Mac::FSEvents",
   "PREREQ_PM" => {},
   "TEST_REQUIRES" => {
-    "Test::More" => "0.99",
-    "autodie" => 0
+    "Test::More" => "0.99"
   },
   "VERSION" => "0.20",
   "test" => {
@@ -80,8 +79,7 @@ my %WriteMakefileArgs = (
 );
 
 my %FallbackPrereqs = (
-  "Test::More" => "0.99",
-  "autodie" => 0
+  "Test::More" => "0.99"
 );
 
 unless ( eval { ExtUtils::MakeMaker->VERSION('6.63_03') } ) {

README.md

@@ -143,14 +143,12 @@ Event monitoring occurs in a separate C thread from the rest of your application
 
     Stop watching.
 
-# SEE ALSO
-
-http://developer.apple.com/documentation/Darwin/Conceptual/FSEvents\_ProgGuide
-
 # AUTHOR
 
 Andy Grundman, <andy@hybridized.org>
 
+Rob Hoelz, <rob@hoelz.ro>
+
 # COPYRIGHT AND LICENSE
 
 Copyright (C) 2009 by Andy Grundman

cpm.yml

@@ -5,4 +5,3 @@ prereqs:
   test:
     requires:
       Test::More: { version: '0.99' }
-      autodie:

dist.ini

@@ -1,4 +1,5 @@
 name = Mac-FSEvents
+author = Andy Grundman <andy@hybridized.org>, Rob Hoelz <rob@hoelz.ro>
 
 [Git::GatherDir]
 exclude_filename = META.json

lib/Mac/FSEvents.pm

@@ -2,7 +2,8 @@ package Mac::FSEvents;
 
 use 5.008008;
 use strict;
-use base 'Exporter';
+use warnings;
+use Exporter 'import';
 
 use Mac::FSEvents::Event;
 
@@ -13,8 +14,8 @@ our %EXPORT_TAGS = ( flags => \@EXPORT_OK );
 
 my @maybe_export_ok = qw(IGNORE_SELF FILE_EVENTS);
 
-require XSLoader;
-XSLoader::load('Mac::FSEvents', $VERSION);
+use XSLoader;
+XSLoader::load(__PACKAGE__, $VERSION);
 
 my %const_args;
 
@@ -249,14 +250,12 @@ Stop watching.
 
 =back
 
-=head1 SEE ALSO
-
-http://developer.apple.com/documentation/Darwin/Conceptual/FSEvents_ProgGuide
-
 =head1 AUTHOR
 
 Andy Grundman, E<lt>andy@hybridized.orgE<gt>
 
+Rob Hoelz, <rob@hoelz.ro>
+
 =head1 COPYRIGHT AND LICENSE
 
 Copyright (C) 2009 by Andy Grundman

lib/Mac/FSEvents/Event.pm

@@ -1,6 +1,7 @@
 package Mac::FSEvents::Event;
 
 use strict;
+use warnings;
 
 sub id                { shift->{id} }
 sub flags             { shift->{flags} }

t/00report.t

@@ -0,0 +1,12 @@
+use strict;
+use warnings;
+use Test::More;
+use POSIX ();
+
+diag "";
+diag `sw_vers`;
+diag "Machine:\t", (POSIX::uname)[4];
+
+pass "ok";
+
+done_testing;

t/01use.t

@@ -1,3 +1,5 @@
+use strict;
+use warnings;
 use Test::More;
 
 use_ok 'Mac::FSEvents';

t/02constructor.t

@@ -1,6 +1,5 @@
-#!/usr/bin/perl
-
 use strict;
+use warnings;
 
 use Mac::FSEvents;
 

t/03event.t

@@ -1,6 +1,5 @@
-#!/usr/bin/perl
-
 use strict;
+use warnings;
 
 use Cwd qw( abs_path );
 use File::Temp;

t/04flags.t

@@ -1,6 +1,5 @@
 use strict;
 use warnings;
-use autodie;
 
 use Cwd qw( getcwd abs_path );
 use File::Path qw( make_path );

t/05fork.t

@@ -1,6 +1,5 @@
 use strict;
 use warnings;
-use autodie;
 
 use IO::Select;
 use File::Temp;
@@ -22,6 +21,7 @@ sub subprocess (&) {
     my ( $action ) = @_;
 
     my $pid = fork;
+    die "failed to fork: $!" if !defined $pid;
 
     if($pid) {
         waitpid $pid, 0;
@@ -48,6 +48,7 @@ subtest 'subprocess events' => sub {
 
     # our subprocess will call DESTROY on the Mac::FSEvents object!
     my $pid = fork;
+    die "failed to fork: $!" if !defined $pid;
     unless($pid) {
         exit 0;
     }