Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object stripping causes issues #41

Merged
merged 5 commits into from
Jul 10, 2020
Merged

Object stripping causes issues #41

merged 5 commits into from
Jul 10, 2020

Conversation

julian-r
Copy link
Member

No description provided.

@julian-r julian-r requested a review from auerj July 10, 2020 09:06
@julian-r julian-r changed the title Fixed #40 Object stripping causes issues Jul 10, 2020
@julian-r julian-r linked an issue Jul 10, 2020 that may be closed by this pull request
Issue with empty sub-objects #40
Closed
@codecov
Copy link

codecov bot commented Jul 10, 2020 •
edited

Codecov Report

Merging #41 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #41   +/-   ##
=======================================
  Coverage   79.07%   79.07%           
=======================================
  Files          14       14           
  Lines        1252     1252           
=======================================
  Hits          990      990           
  Misses        262      262
Flag Coverage Δ
#unittests 79.07% <100.00%> (ø)
Impacted Files Coverage Δ
...ators/python_pydantic/templates/resource_header.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 507a6e9...3149d9e. Read the comment docs.

@julian-r julian-r merged commit bd5f655 into master Jul 10, 2020
@julian-r julian-r deleted the 40-issue-with-empty-objects branch July 10, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trojanowski trojanowski trojanowski left review comments

@auerj auerj auerj approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with empty sub-objects
3 participants
@julian-r @trojanowski @auerj