Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS home bar and footer overlap #45

Merged
merged 9 commits into from
Sep 9, 2020
Merged

Conversation

skalnik
Copy link
Owner

@skalnik skalnik commented Sep 8, 2020

Another attempt to solve the bug in #33 where the iOS home bar and footer overlap.


Closes #33

@vercel
Copy link

vercel bot commented Sep 8, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/skalnik/aqi-wtf/mflajq5uz
✅ Preview: https://aqi-wtf-git-fix-ios-footer-overlap.skalnik.vercel.app

@skalnik
Copy link
Owner Author

skalnik commented Sep 8, 2020

Hm, no dice. https://dev.to/marionauta/avoid-notches-in-your-pwa-with-just-css-al7 does seem to indicate I'm on the right path though.

@skalnik
Copy link
Owner Author

skalnik commented Sep 8, 2020

The footer no longer overlaps! However, the notch cuts into the text when you have a phone sideways now 😅
IMG_5600

The notch in portrait also remains black. I guess we have no control over that ☹

@obra
Copy link
Collaborator

obra commented Sep 8, 2020

Tested on an XS running current release iOS. Totally reasonable for me.

(I wouldn't worry too much about the notch cutting into text. I think we want to play with text size and position more anyway.)

@skalnik
Copy link
Owner Author

skalnik commented Sep 9, 2020

Then I guess this is good to go. We can definitely futz with the spacing around the edges a bit more in the future 👍

I'll merge this now and I'll open a new issue for the notch cutting into the text to dig into separately. Two steps forward, one step back I suppose.

@skalnik skalnik merged commit 16d97df into main Sep 9, 2020
@skalnik skalnik deleted the fix-iOS-footer-overlap branch September 9, 2020 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

on iOS when launched from homescreen, the credits are covered by system UI
2 participants