-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix iOS home bar and footer overlap #45
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/skalnik/aqi-wtf/mflajq5uz |
Hm, no dice. https://dev.to/marionauta/avoid-notches-in-your-pwa-with-just-css-al7 does seem to indicate I'm on the right path though. |
Tested on an XS running current release iOS. Totally reasonable for me. (I wouldn't worry too much about the notch cutting into text. I think we want to play with text size and position more anyway.) |
Then I guess this is good to go. We can definitely futz with the spacing around the edges a bit more in the future 👍 I'll merge this now and I'll open a new issue for the notch cutting into the text to dig into separately. Two steps forward, one step back I suppose. |
Another attempt to solve the bug in #33 where the iOS home bar and footer overlap.
Closes #33