-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to more actionable explanations of the air quality badness. #53
Conversation
These explanations from an EPA publication found at https://www.airnow.gov/sites/default/files/2019-02/air-quality-guide_pm_2015.pdf and are the most "actionable" version of the explanations. Additionally, move the prose descriptions into the HTML and toggle them on and off with CSS. This cuts down the strings in the HTML, reduces the amont of manual DOM twiddling we need to do and reduces the chance that our various tables of the differing levels of badness will get out of sync.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/skalnik/aqi-wtf/mgweq72wn |
That's some good thinking! I'm heading to bed since I have an early dentist appt but I'll check these PRs out tomorrow. |
Oof...Sleep well. Hope it goes smoothly. If this technique works for you, I'll update the rest of the stuff to use the same style. |
What if instead we moved the descriptions to below the sensor information? I think that might look a bit nicer and would make the lack of centering possibly feel reasonable.
…On Fri, Sep 11, 2020, at 7:37 PM, Mike Skalnik wrote:
This PR overall looks good. I think left justifying the descriptions mostly makes sense, but it also can look strange. I wonder if we should center some of the shorter ones. (Ignore the AQI # since I just manually changed the class to `good`)
Screen Shot 2020-09-11 at 7 36 21 PM <https://user-images.githubusercontent.com/2546/92985309-328a7e00-f466-11ea-967d-3efebb30552f.png>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#53 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAALC2GFBWEJTSVKHV2UZ23SFLNHFANCNFSM4RGRRDXQ>.
|
Seems reasonable to try! |
I dig it 👍 |
These explanations from an EPA publication found at https://www.airnow.gov/sites/default/files/2019-02/air-quality-guide_pm_2015.pdf and are the most "actionable" version of the explanations.
Additionally, move the prose descriptions into the HTML and toggle them on and off with CSS. This cuts down the strings in the HTML, reduces the amount of manual DOM twiddling we need to do and reduces the chance that our various tables of the differing levels of badness will get out of sync.
I'm gonna stop messing around for now.