Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to more actionable explanations of the air quality badness. #53

Merged
merged 2 commits into from
Sep 12, 2020

Conversation

obra
Copy link
Collaborator

@obra obra commented Sep 11, 2020

These explanations from an EPA publication found at https://www.airnow.gov/sites/default/files/2019-02/air-quality-guide_pm_2015.pdf and are the most "actionable" version of the explanations.

Additionally, move the prose descriptions into the HTML and toggle them on and off with CSS. This cuts down the strings in the HTML, reduces the amount of manual DOM twiddling we need to do and reduces the chance that our various tables of the differing levels of badness will get out of sync.

I'm gonna stop messing around for now.

These explanations from an EPA publication found at https://www.airnow.gov/sites/default/files/2019-02/air-quality-guide_pm_2015.pdf and are the most "actionable" version of the explanations.

Additionally, move the prose descriptions into the HTML and toggle them on and off with CSS. This cuts down the strings in the HTML, reduces the amont of manual DOM twiddling we need to do and reduces the chance that our various tables of the differing levels of badness will get out of sync.
@vercel
Copy link

vercel bot commented Sep 11, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/skalnik/aqi-wtf/mgweq72wn
✅ Preview: https://aqi-wtf-git-fork-obra-update-warnings.skalnik.vercel.app

@skalnik
Copy link
Owner

skalnik commented Sep 11, 2020

Additionally, move the prose descriptions into the HTML and toggle them on and off with CSS. This cuts down the strings in the HTML, reduces the amount of manual DOM twiddling we need to do and reduces the chance that our various tables of the differing levels of badness will get out of sync.

That's some good thinking! I'm heading to bed since I have an early dentist appt but I'll check these PRs out tomorrow.

@obra
Copy link
Collaborator Author

obra commented Sep 11, 2020

Oof...Sleep well. Hope it goes smoothly. If this technique works for you, I'll update the rest of the stuff to use the same style.

@skalnik
Copy link
Owner

skalnik commented Sep 12, 2020

This PR overall looks good. I think left justifying the descriptions mostly makes sense, but it also can look strange. I wonder if we should center some of the shorter ones. (Ignore the AQI # since I just manually changed the class to good)

Screen Shot 2020-09-11 at 7 36 21 PM

@obra
Copy link
Collaborator Author

obra commented Sep 12, 2020 via email

@skalnik
Copy link
Owner

skalnik commented Sep 12, 2020

What if instead we moved the descriptions to below the sensor information? I think that might look a bit nicer and would make the lack of centering possibly feel reasonable.

Seems reasonable to try!

@obra
Copy link
Collaborator Author

obra commented Sep 12, 2020

Screen Shot 2020-09-11 at 8 05 16 PM

Screen Shot 2020-09-11 at 8 05 04 PM

Later, it may be time to play with font sizes some more. (possibly dropping the sensor link font size)

@skalnik
Copy link
Owner

skalnik commented Sep 12, 2020

I dig it 👍

@skalnik skalnik merged commit 3aea848 into skalnik:main Sep 12, 2020
@obra obra deleted the update-warnings branch September 12, 2020 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants