Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set python test runner niceness to 10 #161

Merged
merged 1 commit into from Apr 7, 2015
Merged

Set python test runner niceness to 10 #161

merged 1 commit into from Apr 7, 2015

Conversation

kunev
Copy link
Contributor

@kunev kunev commented Apr 6, 2015

По отпочнатата тема в /pull/160.

На теория винаги трябва да почваме с niceness 0, но да речем, че в случая не боли да сме предпазливи.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.85% when pulling 5daee99 on kunev:test-runner-niceness into 0ac96d3 on skanev:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.85% when pulling 5daee99 on kunev:test-runner-niceness into 0ac96d3 on skanev:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.85% when pulling 5daee99 on kunev:test-runner-niceness into 0ac96d3 on skanev:master.

@mitio
Copy link
Collaborator

mitio commented Apr 7, 2015

@kunev Тук е влязъл и един паразитен commit, който беше част от #160. Направи един rebase & force push, защото merge-нах #160.

Сподели какви са ти съображенията да трябва да започваме от 0 и как би трябвало да се променя с времето.

Интересно ми е и защо е необходимо това с initial_niceness.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.85% when pulling cffab03 on kunev:test-runner-niceness into 7ab3954 on skanev:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.85% when pulling cffab03 on kunev:test-runner-niceness into 7ab3954 on skanev:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.85% when pulling cffab03 on kunev:test-runner-niceness into 7ab3954 on skanev:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.85% when pulling cffab03 on kunev:test-runner-niceness into 7ab3954 on skanev:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.85% when pulling cffab03 on kunev:test-runner-niceness into 7ab3954 on skanev:master.

@kunev
Copy link
Contributor Author

kunev commented Apr 7, 2015

Освен ако няко нагоре по дървото с процесите не променя niceness-а си, или не пуска някой child процес с различен niceness, би трябвало в началото и niceness-а на runner.py да е 0.

Евентуално ако niceness-а не е 0 в началото с initial_niceness смятам колко трябва да се увеличи, за да стигне до десет.

Тая гимнастика е нужна поради факта, че os.nice приема с колко да се увеличи niceness-а, а не стойността, на която да бъде сетнат.

От друга страна това означава, че винаги ще върви само с niceness 10, без значение как е пуснат, което може би е малко неприятно. Може да сетваме 10, ако е нула, а иначе да оставяме текущия, т.к. който го е сетнал най-вероятно е имал някаква добра причина за това.

Иначе @vladimiroff имаше съмнения дали multiprocessing.Process ще запази niceness-а. Експериментално стигнах до извода, че децата създадени така имат същия niceness, така че с това сме ок.

mitio added a commit that referenced this pull request Apr 7, 2015
Set python test runner niceness to 10
@mitio mitio merged commit 21d5ddf into skanev:master Apr 7, 2015
@mitio
Copy link
Collaborator

mitio commented Apr 7, 2015

Деплойнах промените. @kunev @vladimiroff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants