Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] #9

Open
AtomicStryker opened this issue Mar 14, 2018 · 6 comments
Open

[Feature Request] #9

AtomicStryker opened this issue Mar 14, 2018 · 6 comments

Comments

@AtomicStryker
Copy link

AtomicStryker commented Mar 14, 2018

This tool looks amazing! Could i bother you with some feature requests?

1: When a user scrolls past the end of a sheet diff, automatically jump to the next sheet in both src and dst and extract. For user convenience. Make this configurable?

[EDIT] Your showcase gif shows exactly this, perhaps there is a way to do this i am overlooking

2: Add a flag or option for more automated workbook diff:

Assume i have two versions of the same excel workbook. The sheets are in the same order and have the same names. There have been changes on some sheets (mostly row additions, cell edits).

Right now, the user has to click his way through the gui to change the sheet for both source and dest files and then "extract diff". #1 would already help, but I would like for the tool to diff all sheets to begin with (under the checked assumption all sheets have the same names and order), and then perhaps mark sheets with diffs in the sheet selection dropdown (color them red or something). Have the GUI jump to the first (sheet) diff.

@skanmera
Copy link
Owner

Thank you for your requests.
Since I think there is demand for these requests, I will implement them.

@skanmera
Copy link
Owner

Please check v1.4.0.

@AtomicStryker
Copy link
Author

Thank you so much! I will check monday at work, where we have nasty excel sheets of all sizes and merge conflicts

@AtomicStryker
Copy link
Author

As promised, have some feedback:

I have enabled the new settings in "behaviour": Focus first ... Move to next ... Move to prev ... Use Batch ... Make sheet pair...

The Tool is so much faster to use now, thank you! Found some bugs if you'd like them:

When the sheet is long enough to have a scrollbar, scrolling "down" to get to the next sheet does not work.

Despite having batch extraction enabled, there are no differences marked (no color at all) in the sheet dropdown. Do i have to do something else?

Clicking on disabled "prev" and "next" buttons (when in first or last sheet) hit the "option dropdown" button despite it being quite far away

@skanmera
Copy link
Owner

Sorry for replying so late.
Thank you for your feedback.

When the sheet is long enough to have a scrollbar, scrolling "down" to get to the next sheet does not work.

It has some margin to prevent malfunction.
It will work when you scroll more little after the scrollbar reached the end.

Despite having batch extraction enabled, there are no differences marked (no color at all) in the sheet dropdown. Do i have to do something else?

You mean the corresponding item in the dropdown is not colored despite the difference in table view?

Clicking on disabled "prev" and "next" buttons (when in first or last sheet) hit the "option dropdown" button despite it being quite far away

I will fix this bug in the next version.

@AtomicStryker
Copy link
Author

AtomicStryker commented Jun 19, 2018

missingcolors

As you can see, despite existing diffs there is no color in the dropdown.

And yes, i am sure there is a bug in the scrolling mechanic, because i can literally spin the wheel on my mouse and it is not enough to swap to the next sheet. I have a video of it too but github doesn't support video file upload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants