Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RRULE: Fix floating UNTIL with dateutil > 2.6.1 #115

Merged
merged 4 commits into from
Jul 8, 2018
Merged

RRULE: Fix floating UNTIL with dateutil > 2.6.1 #115

merged 4 commits into from
Jul 8, 2018

Commits on Apr 25, 2018

  1. RRULE: Fix floating UNTIL with dateutil > 2.6.1

    @Unrud
    Unrud committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    829d17e View commit details
    Browse the repository at this point in the history

  2. RRULE: always ignore time zone 

    dateutil raises an exception when UNTIL is UTC and ``dtstart`` is not set.
This restores the old  behaviour, because ``isinstance(dtstart, datetime.date)`` is always true.
    @Unrud
    Unrud committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    8e28129 View commit details
    Browse the repository at this point in the history

  3. Revert "RRULE: always ignore time zone" 

    This reverts commit 8e28129.

The original behaviour was wrong. ``ignoretz=isinstance(dtstart, datetime.date)`` is always True, this causes vobject to always drop the time zone from UNTIL. If DTSTART has a time zone and UNTIL is UTC, the time zone of UNTIL gets replaced by the time zone of DTSTART without adjustment.
    @Unrud
    Unrud committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    2872f70 View commit details
    Browse the repository at this point in the history

  4. RRULE: Add workaround for dateutil<=2.7.2 

    dateutil/dateutil@2846226#diff-0cf96106a7dd4a241fca4079eac4c0a4
    @Unrud
    Unrud committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    0ec6ad3 View commit details
    Browse the repository at this point in the history