Skip to content
This repository has been archived by the owner on Jan 4, 2018. It is now read-only.

Make sure we notify preact in disconnectedCallback #5

Closed
freeman opened this issue Nov 2, 2017 · 4 comments
Closed

Make sure we notify preact in disconnectedCallback #5

freeman opened this issue Nov 2, 2017 · 4 comments

Comments

@freeman
Copy link

freeman commented Nov 2, 2017

So that componentWillUnmount lifecycle methods are properly called on any child preact components.

See skatejs/skatejs#1244

@treshugart
Copy link
Member

I wonder if it would be better to "unmount" the component, maybe replacing it with a div or something if you can't do that, so that it is compatible with whatever Preact does in the future on unmounting.

@treshugart
Copy link
Member

This should also be done in https://github.com/skatejs/renderer-react.

@Hotell
Copy link
Contributor

Hotell commented Nov 7, 2017

so this is a bug on our side or on the renderers side @treshugart ?

@treshugart
Copy link
Member

@Hotell it should be done within the renderers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants