This repository has been archived by the owner on Jan 4, 2018. It is now read-only.
Make sure we notify preact in disconnectedCallback #5
Comments
I wonder if it would be better to "unmount" the component, maybe replacing it with a div or something if you can't do that, so that it is compatible with whatever Preact does in the future on unmounting. |
This should also be done in https://github.com/skatejs/renderer-react. |
so this is a bug on our side or on the renderers side @treshugart ? |
@Hotell it should be done within the renderers. |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
So that
componentWillUnmount
lifecycle methods are properly called on any child preact components.See skatejs/skatejs#1244
The text was updated successfully, but these errors were encountered: