Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unmount react component when disconnected #1260

Closed
treshugart opened this issue Dec 1, 2017 · 2 comments
Closed

Unmount react component when disconnected #1260

treshugart opened this issue Dec 1, 2017 · 2 comments
Labels
package: element-react

Comments

@treshugart
Copy link
Member

Do the same thing as: skatejs/renderer-preact#5
@treshugart treshugart mentioned this issue Dec 1, 2017
Closed
@NMinhNguyen
Copy link
Member

NMinhNguyen commented Apr 17, 2018 •
edited

@treshugart inside disconnectedCallback, should super.disconnectedCallback() be called first (the way it is in skatejs/renderer-preact#5) or last? I'll try to prepare a PR for this in the next few days :)

NMinhNguyen added a commit to NMinhNguyen/skatejs that referenced this issue Apr 17, 2018
@NMinhNguyen
Unmount React component when disconnected. Closes skatejs#1260
70bd332
@NMinhNguyen NMinhNguyen mentioned this issue Apr 17, 2018
Merged
6 tasks
@treshugart
Copy link
Member Author

@NMinhNguyen I would think, ideally, first? I generally try to call super as soon as possible, unless you need to do something before. I'm looking forward to the PR!

NMinhNguyen added a commit to NMinhNguyen/skatejs that referenced this issue Apr 21, 2018
@NMinhNguyen
Unmount React component when disconnected. Closes skatejs#1260
50da9ec
NMinhNguyen added a commit to NMinhNguyen/skatejs that referenced this issue Apr 23, 2018
@NMinhNguyen
Unmount React component when disconnected. Closes skatejs#1260
a016898
NMinhNguyen added a commit to NMinhNguyen/skatejs that referenced this issue Apr 23, 2018
@NMinhNguyen
Unmount React component when disconnected. Closes skatejs#1260
55c8eb4
treshugart added a commit that referenced this issue Apr 23, 2018
@treshugart
Merge pull request #1432 from NMinhNguyen/unmount-react-component-whe…
4ad3b9b 
…n-disconnected

Unmount React component when disconnected. Closes #1260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package: element-react
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@treshugart @NMinhNguyen