fix: skip and ref behaviour for vdom.elementVoid

src/api/vdom.js

@@ -3,7 +3,6 @@ import {
   attributes,
   elementClose,
   elementOpen,
-  elementVoid,
   skip,
   symbols,
   text,
@@ -247,11 +246,6 @@ function stackClose(tname) {
   return tname(props, () => chren.forEach(args => args[0](...args[1])));
 }
 
-function stackVoid(...args) {
-  stackOpen(...args);
-  return stackClose(args[0]);
-}
-
 // Incremental DOM overrides
 // -------------------------
 
@@ -268,7 +262,10 @@ const newElementOpen = wrapIdomFunc(elementOpen, stackOpen);
 const newElementClose = wrapIdomFunc(elementClose, stackClose);
 
 // Ensure we call our overridden functions instead of the internal ones.
-const newElementVoid = wrapIdomFunc(elementVoid, stackVoid);
+function newElementVoid(tag, ...args) {
+  newElementOpen(tag, ...args);
+  return newElementClose(tag);
+}
 
 // Text override ensures their calls can queue if using function helpers.
 const newText = wrapIdomFunc(text);

test/unit/vdom/ref.js

@@ -73,12 +73,24 @@ function test(name, el) {
 
 describe('vdom/ref', () => {
   test('normal elements', 'div');
+
   test('custom elements', define('x-test', {
     render() {
       vdom.element('slot');
     },
   }));
+
   test('function helpers', (lprops, chren) => {
     vdom.element('div', lprops, chren);
   });
+
+  it('void elements', done => {
+    const Elem = define('x-test', {
+      render() {
+        vdom.elementVoid('div', null, null, 'ref', () => done());
+      },
+    });
+    const elem = new Elem();
+    fixture(elem);
+  });
 });

test/unit/vdom/skip.js

@@ -129,4 +129,23 @@ describe('vdom/skip', () => {
       done
     );
   });
+
+  it('re-rendering an void, skipped element should keep the mutated content', done => {
+    const Elem = define('x-test', {
+      props: {
+        test: {},
+      },
+      render() {
+        elementVoid('div', null, null, 'skip', true);
+      },
+    });
+    const elem = new Elem();
+    fixture(elem);
+    afterMutations(
+      () => (elem[symbols.shadowRoot].firstElementChild.textContent = 'testing'),
+      () => props(elem, { test: 0 }),
+      () => expect(elem[symbols.shadowRoot].firstElementChild.textContent).to.equal('testing'),
+      done
+    );
+  });
 });