Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.1 CI #100

Merged
merged 2 commits into from
Apr 10, 2022
Merged

PHP 8.1 CI #100

merged 2 commits into from
Apr 10, 2022

Conversation

JindrichPilar
Copy link
Member

@JindrichPilar JindrichPilar commented Jan 29, 2022 •
edited
Loading

Fixes #99

Nemeli jsme matrix verzi PHP i pro PHPStan a tak jsme nedostali error automaticky.

@coveralls
Copy link

coveralls commented Jan 29, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1766951106

  • 0 of 12 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.1%) to 83.611%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Wsdl/Event/RequestFailEvent.php 0 4 0.0%
src/Wsdl/Event/RequestPostEvent.php 0 4 0.0%
src/Wsdl/Event/RequestPreEvent.php 0 4 0.0%
Totals Coverage Status
Change from base Build 476195466: -3.1%
Covered Lines: 301
Relevant Lines: 360
💛 - Coveralls

@JindrichPilar JindrichPilar self-assigned this Jan 29, 2022
@JindrichPilar JindrichPilar added this to the Verze 3.0 milestone Jan 29, 2022
@JindrichPilar JindrichPilar marked this pull request as ready for review January 29, 2022 22:19
@JindrichPilar JindrichPilar mentioned this pull request Jan 29, 2022
Closed
sinacek
sinacek approved these changes Jan 30, 2022
View reviewed changes
Copy link
Member

@sinacek sinacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jan-stanek jan-stanek mentioned this pull request Mar 12, 2022
Merged
2 tasks
@sinacek sinacek merged commit 207eab3 into skaut:3.x Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinacek sinacek sinacek approved these changes

@fmasa fmasa Awaiting requested review from fmasa

Assignees

@JindrichPilar JindrichPilar

Labels
Bugfix
Projects
None yet
Milestone
Verze 3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JindrichPilar @coveralls @sinacek