Restore nullability for displayName in UpsertPlayerInfo (PaperMC#1172)

This makes the UpsertPlayerInfo's displayName truly nullable as before the ComponentHolder was introduced.
skbeh · Jan 17, 2024 · 10c8e89 · 10c8e89
1 parent d11f13d
commit 10c8e89
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/proxy/src/main/java/com/velocitypowered/proxy/tablist/VelocityTabList.java b/proxy/src/main/java/com/velocitypowered/proxy/tablist/VelocityTabList.java
@@ -110,8 +110,12 @@ public void addEntry(TabListEntry entry1) {
       if (!Objects.equals(previousEntry.getDisplayNameComponent().orElse(null),
           entry.getDisplayNameComponent().orElse(null))) {
         actions.add(UpsertPlayerInfo.Action.UPDATE_DISPLAY_NAME);
-        playerInfoEntry.setDisplayName(new ComponentHolder(player.getProtocolVersion(),
-              entry.getDisplayNameComponent().get()));
+        playerInfoEntry.setDisplayName(entry.getDisplayNameComponent().isEmpty()
+                ?
+                null :
+                new ComponentHolder(player.getProtocolVersion(),
+                        entry.getDisplayNameComponent().get())
+        );
       }
       if (!Objects.equals(previousEntry.getLatency(), entry.getLatency())) {
         actions.add(UpsertPlayerInfo.Action.UPDATE_LATENCY);
@@ -140,8 +144,12 @@ public void addEntry(TabListEntry entry1) {
       playerInfoEntry.setProfile(entry.getProfile());
       if (entry.getDisplayNameComponent().isPresent()) {
         actions.add(UpsertPlayerInfo.Action.UPDATE_DISPLAY_NAME);
-        playerInfoEntry.setDisplayName(new ComponentHolder(player.getProtocolVersion(),
-              entry.getDisplayNameComponent().get()));
+        playerInfoEntry.setDisplayName(entry.getDisplayNameComponent().isEmpty()
+                ?
+                null :
+                new ComponentHolder(player.getProtocolVersion(),
+                        entry.getDisplayNameComponent().get())
+        );
       }
       if (entry.getChatSession() != null) {
         actions.add(UpsertPlayerInfo.Action.INITIALIZE_CHAT);

diff --git a/proxy/src/main/java/com/velocitypowered/proxy/tablist/VelocityTabListEntry.java b/proxy/src/main/java/com/velocitypowered/proxy/tablist/VelocityTabListEntry.java
@@ -80,7 +80,11 @@ public TabListEntry setDisplayName(@Nullable Component displayName) {
     this.displayName = displayName;
     UpsertPlayerInfo.Entry upsertEntry = this.tabList.createRawEntry(this);
     upsertEntry.setDisplayName(
-        new ComponentHolder(this.tabList.getPlayer().getProtocolVersion(), displayName));
+            displayName == null
+                    ?
+                    null :
+                    new ComponentHolder(this.tabList.getPlayer().getProtocolVersion(), displayName)
+    );
     this.tabList.emitActionRaw(UpsertPlayerInfo.Action.UPDATE_DISPLAY_NAME, upsertEntry);
     return this;
   }