feat(Toggle): add prop 'child' and 'childPosition' #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lossir
reviewed
Sep 4, 2020
YakOFF19
force-pushed
the
toggle-add-child-1723
branch
from
1a97689
to
bec683c
Compare
lossir
reviewed
Sep 8, 2020
There was a problem hiding this comment.
Предлагаю добавить пример в Toggle.md.
Ещё текст коммита "устарел", касательно названий пропов. К тому же, пропchildren доступен всегда. Просто сейчас ты начал его использовать. Поэтому текст коммита стоит заменить на что подобное:
feat(Toggle): add caption support by using `children`
Скриншотные тесты тоже не помешали бы. Надо бы потестировать базовую линию, и многострочный вариант, ко всему прочему.
YakOFF19
force-pushed
the
toggle-add-child-1723
branch
2 times, most recently
from
0533d77
to
9fe06f6
Compare
lossir
reviewed
Sep 10, 2020
YakOFF19
force-pushed
the
toggle-add-child-1723
branch
from
9fe06f6
to
6173dd3
Compare
lossir
reviewed
Sep 10, 2020
YakOFF19
force-pushed
the
toggle-add-child-1723
branch
from
6173dd3
to
42d4d14
Compare
lossir
reviewed
Sep 10, 2020
YakOFF19
force-pushed
the
toggle-add-child-1723
branch
from
42d4d14
to
984a207
Compare
rustho
reviewed
Sep 11, 2020
YakOFF19
force-pushed
the
toggle-add-child-1723
branch
from
91d79e9
to
d67aea2
Compare
lossir
reviewed
Sep 11, 2020
packages/react-ui/components/Toggle/__stories__/Toggle.stories.tsx
Outdated
Show resolved
Hide resolved
lossir
reviewed
Sep 14, 2020
packages/react-ui/components/Toggle/__stories__/Toggle.stories.tsx
Outdated
Show resolved
Hide resolved
zhzz
requested changes
Sep 15, 2020
zhzz
requested changes
Sep 21, 2020
zhzz
requested changes
Sep 23, 2020
|
Подправил скриншоты DropdownMenu в IE. Они были не совсем корректными. Я не выявил прямой зависимости между их падением и изменениями в Тоггле. Но вроде ничего на самом деле не сломалось. |
zhzz
previously approved these changes
Sep 28, 2020
lossir
reviewed
Sep 28, 2020
lossir
approved these changes
Oct 1, 2020
zhzz
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавлена возможность передать child.
Дочерний элемент может быть расположен справа или слева от тоггла.
Значение переключается в том числе при клике по child.
Closes #1723