feat(Calendar): added period #3258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Voldemart96Rus
force-pushed
the
IF-298-added-period-calendar
branch
2 times, most recently
from
6228ad1
to
073ed7d
Compare
Voldemart96Rus
force-pushed
the
IF-298-added-period-calendar
branch
from
073ed7d
to
8271705
Compare
Voldemart96Rus
force-pushed
the
IF-298-added-period-calendar
branch
from
8271705
to
a6a91cc
Compare
lossir
reviewed
Sep 8, 2023
packages/react-ui/components/Calendar/__stories__/Calendar.creevey.stories.tsx
Outdated
Show resolved
Hide resolved
Voldemart96Rus
force-pushed
the
IF-298-added-period-calendar
branch
from
5c3d362
to
43c01d9
Compare
…to IF-298-added-period-calendar # Conflicts: # packages/react-ui/components/Calendar/Calendar.md # packages/react-ui/components/Calendar/Calendar.tsx # packages/react-ui/components/Calendar/DayCellView.styles.ts # packages/react-ui/components/Calendar/DayCellView.tsx # packages/react-ui/components/Calendar/Month.tsx # packages/react-ui/components/Calendar/__stories__/Calendar.stories.tsx
…to IF-298-added-period-calendar
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Проблема
Нету выбора периода в компоненте календаря
Решение
Добавил 2 новых пропса для отображения периода, добавил тесты скриншотные + @testing-library/react
Ссылки
resolve IF-298 Календарь с периодом
Чек-лист перед запросом ревью
Добавлены тесты на все изменения
✅ unit-тесты для логики
✅ скриншоты для верстки и кросс-браузерности
⬜ нерелевантно
Добавлена (обновлена) документация
✅ styleguidist для пропов и примеров использования компонентов
✅ jsdoc для утилит и хелперов
✅ комментарии для неочевидных мест в коде
⬜ прочие инструкции (
README.md,contributing.mdи др.)⬜ нерелевантно
Изменения корректно типизированы
✅ без использования
any(см. PR2856)⬜ нерелевантно
Прочее
✅ все тесты и линтеры на CI проходят
✅ в коде нет лишних изменений
✅ заголовок PR кратко и доступно отражает суть изменений (он попадет в changelog)