Forbid unicode in domain literals

Per RFC 6531, the addition of unicode doesn't extend to domain literals.
skeggse · Oct 21, 2018 · a622c30 · a622c30
1 parent 376864a
commit a622c30
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/parser.js b/lib/parser.js
@@ -314,7 +314,7 @@ class Parser {
 
                 case '"':
                     // End of quoted string
-                    if (needBeQuoted || !this._normalizeUnnecessaryQuoted) {
+                    if (needBeQuoted || !this._normalizeUnnecessaryQuoted || !string) {
                         return `"${string}"`;
                     }
 
@@ -848,7 +848,7 @@ class Parser {
                     const code = rune.codePointAt(0);
 
                     // '\r', '\n', ' ', and '\t' have already been parsed above
-                    if ((code !== 127 && internals.c1Controls(code)) || code === 0 || rune === '[') {
+                    if ((code !== 127 && internals.c1Controls(code)) || code === 0 || code > 127 || rune === '[') {
                         // Fatal error
                         this.diagnose(Constants.diagnoses.errExpectingDTEXT);
                         break;

diff --git a/test/tests.json b/test/tests.json
@@ -127,7 +127,7 @@
     ["test@iana.org(comment\\)", "errUnclosedComment"],
     ["test@iana.org(comment\\", "errBackslashEnd"],
     ["test@[RFC-5322-domain-literal]", "rfc5322DomainLiteral"],
-    ["test@[RFC-5322-郵件ñó-domain-literal]", "rfc5322DomainLiteral"],
+    ["test@[RFC-5322-郵件ñó-domain-literal]", "errExpectingDTEXT"],
     ["test@[RFC-5322]-domain-literal]", "errATEXTAfterDomainLiteral"],
     ["test@[RFC-5322].domain-literal]", "errDotAfterDomainLiteral"],
     ["test@[RFC-5322-[domain-literal]", "errExpectingDTEXT"],