Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for 0.8.x #2

Closed
skeggse opened this issue Sep 13, 2015 · 2 comments
Closed

Support for 0.8.x #2

skeggse opened this issue Sep 13, 2015 · 2 comments
Assignees
@skeggse
Labels
documentation

Comments

@skeggse
Copy link
Owner

skeggse commented Sep 13, 2015

The tests currently fail for Node 0.8.x. Should we drop support or try to make chai happy?
@Marsup
Copy link
Contributor

Marsup commented Sep 13, 2015

Node 0.8 is way past support time, I vote for deprecation.

@skeggse skeggse closed this as completed Sep 13, 2015
@skeggse skeggse reopened this Sep 13, 2015
@skeggse
Copy link
Owner Author

skeggse commented Sep 13, 2015

Ha haven't actually pushed this yet.

skeggse added a commit that referenced this issue Sep 13, 2015
@skeggse
[1.2.0] drop Node 0.8, fix style, switch to lab/code
52adfc5 
Drop support for Node 0.8, fixes #1.

Switch to lab/code from mocha/chai per #2. Move tests to _tests.json_, add
library usage tests.

Add support for single TLD in tldWhitelist as string.

Fix whitespace for switch statements.

Signed-off-by: Eli Skeggs <skeggse@gmail.com>
@skeggse skeggse closed this as completed Sep 13, 2015
@skeggse skeggse reopened this Sep 13, 2015
@skeggse skeggse closed this as completed Sep 13, 2015
@skeggse skeggse mentioned this issue Sep 13, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skeggse skeggse

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hueniverse @Marsup @skeggse