chore: add TS type declaration and pkg.json types entry

[alexsasharegan]

Convenience for TypeScript and vscode users.

[skeggse]

Ah, thanks! I'm just now noticing that we didn't deprecate the callback function like we were going to - there isn't any async behavior anymore.

[alexsasharegan]

Let me know if you want it documented differently, or if you update the API and would rather have me update the typings.

[skeggse]

I'm not familiar with typescript, but is there any reason to not follow hapijs' style guidelines in regards to semicolon usage and indentation?

[alexsasharegan]

I didn't catch that, sorry! I'll see about getting my formatter to cooperate. Do you guys have an .editorconfig?

[skeggse]

Let me know if you want it documented differently, or if you update the API and would rather have me update the typings.

I'll update the API and docs - can you update the ts definition to remove the optional callback? (I'm not at my computer right now but will be shortly)

[alexsasharegan]

I just scanned the style guide briefly. Basically just switched to using spaces and semis. Also removed the callback param.

[skeggse]

Joi appears to be the only project that includes a .editorconfig. We use lab to validate adherence to our style guide. See also outmoded/hapi-contrib#38.

[skeggse]

Merged, thanks!

[alexsasharegan]

Awesome! Do you have a set release cycle? When might this make it onto npm so I can remove my own typings?

[skeggse]

I'll go update the docs when I'm at my computer and release that together as 3.1.1. (so probably tonight)

[alexsasharegan]

Cheers! Thank you!

[Marsup]

@skeggse It's not going to be enough, .npmignore will drop it on publish.

[alexsasharegan]

Doesn't .npmignore whitelist lib/*?

[skeggse]

Released in 3.1.1 (callback is just deprecated until 4.0.0). The npmignore does correctly whitelist lib/, though we could move that definition into the files array of the package.json instead.

[Marsup]

My bad, all other hapi projects put it at the root, reflex :p

[alexsasharegan]

True! I just followed what you guys had going. Didn't even realize I saved myself that faux pas!