-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation in Inference Network class #113
Labels
documentation
Improvements or additions to documentation
good first issue
Good for newcomers
help wanted
Extra attention is needed
up-for-grabs
Comments
Hello can you affiliate me this issue ? |
moki1202
added a commit
to moki1202/NBA-Search
that referenced
this issue
Jan 30, 2021
I have tried to Improve documentation in Inference Network class skekre98#113
Just added some documentation for this file in #152. |
Florent18570
added a commit
to Florent18570/NBA-Search
that referenced
this issue
Mar 28, 2021
Improve documentation in Inference Network class skekre98#113
Is this PR still being worked on, if not I would like to contribute :) |
Update inference_network.py |
Hello there , this PR is it still open I would like to contribute ? |
Hi @V3NN0W, apologies this issue was meant to be closed a while ago. |
Hello skekre98,
thank you for your quick response. Apart from this topic I wanted to see
with you, maybe you know more than me, but why not integrated a video
player which would show the important moments or actions of a match when
clicked? Of course it goes without saying that we need to create a clean
YouTube channel for the site, but that sounds good to me, I'd love to hear
from you.
I wish you a good evening, take care of yourself.
Cordially
V3NN0W.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
good first issue
Good for newcomers
help wanted
Extra attention is needed
up-for-grabs
Description of feature/enhancement
Current documentation in
../inference/inference_network.py
is lacking. Could use better documentation.Description of implementation
See
../modules/scraper.py
for examples of documentation. Should be in following format:Why this is a good feature/enhancement
Better documentation would make it easier for first time contributors to jump right into code base.
Additional context
n/a
The text was updated successfully, but these errors were encountered: