Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Remove "Shader text" property feature #13

Open
skeletonbow opened this issue May 20, 2022 · 0 comments
Open

RFE: Remove "Shader text" property feature #13

skeletonbow opened this issue May 20, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@skeletonbow
Copy link
Owner

The "Shader text" property that first appears when you add the "User-defined-shader" property filter to a source has never really worked properly and is just clutter in the user interface that likely confuses some non-developer end users. I doubt there are many developers that would use it either as it is of extremely limited use at best.

Removing this feature would simplify the user interface and reduce non-developer end-user confusion. Nobody would likely miss it, and OBS Shaderfilter 1.21.1 would still exist if they needed to use this for some odd reason.

For this reason, I plan to remove it from my build in the future unless I come across a good enough reason to keep it. The "Load shader text from file" checkbox can then be removed also, and replaced by a "Shader file:" textbox.

Another option to consider, would be to scan the supplied shader examples directory and preload a combo box with all of the shaders so users can just pick one without having to navigate their hard disk, and then have an optional "manually specify shader file" option or something to navigate to a custom location to load a shader file.

All things worth exploring somewhat before committing to any specific changes though.

@skeletonbow skeletonbow added the enhancement New feature or request label May 31, 2022
@skeletonbow skeletonbow added this to the 2.0 Alpha Test Release 1 milestone May 31, 2022
@skeletonbow skeletonbow changed the title Remove "Shader text" property feature RFE: Remove "Shader text" property feature May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant