-
-
Notifications
You must be signed in to change notification settings - Fork 300
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'skeletonlabs:dev' into chore/tableOfContents-safeguard
- Loading branch information
Showing
9 changed files
with
101 additions
and
42 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@skeletonlabs/skeleton": patch | ||
--- | ||
|
||
Fix Toast jiggle when last toast remain |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,12 @@ | ||
name: 📗 Report Docs Issue | ||
description: See a typo? Outdated or incorrect information? Let us know! | ||
title: "<title>" | ||
description: Use this to report a typo or incorrect information. | ||
labels: [documentation] | ||
body: | ||
- type: markdown | ||
attributes: | ||
value: Sometimes something slips through the cracks, and the documentation is not quite right. Thanks for letting us know! | ||
- type: input | ||
id: link | ||
attributes: | ||
label: Link to the Page | ||
- type: textarea | ||
id: quote | ||
attributes: | ||
label: Describe the Issue | ||
- type: dropdown | ||
id: participate | ||
attributes: | ||
label: Are you able to create a Pull Request with the fix? | ||
options: | ||
- 'Yes' | ||
- 'No' | ||
label: Describe the Issue (screenshots encouraged!) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,22 @@ | ||
## Before submitting the PR: | ||
- [ ] Does your PR reference an issue? If not, please [chat to the team on Discord](https://discord.gg/EXqV7W8MtY) or [GitHub](https://github.com/skeletonlabs/skeleton/discussions) before submission. | ||
- [ ] Did you update and run tests before submission using `npm run test`? | ||
- [ ] Does your branch follow our [naming convention](https://www.skeleton.dev/docs/contributing)? If not, please amend the branch name using `branch -m new-branch-name` | ||
- [ ] Did you update documentation related to your new feature or changes? | ||
## Linked Issue | ||
|
||
## What does your PR address? | ||
Closes #{issueNumber} | ||
|
||
Please briefly describe your changes here. | ||
## Description | ||
|
||
### Tips | ||
- Tap "convert to draft" to indicate this is work in progress. | ||
- Link to an issue using the verbiage [Fixes #XX](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) | ||
- Linked issues will auto-close when the PR is merged. | ||
{description} | ||
|
||
## Changsets | ||
|
||
Changesets automate our changelog. If you modify files in `/package/skeleton`, run `pnpm changeset`, follow the prompts, then commit the markdown file. Changes that add features should be `minor` while chores and bugfixes should be `patch`. Please prefix the changeset message with `feat:`, `bugfix:` or `chore:`. | ||
|
||
## Checklist | ||
|
||
Please read and apply all [contribution requirements](https://www.skeleton.dev/docs/contributing/style-guide#feature-branches). | ||
|
||
- [ ] This PR targets the `dev` branch (NEVER `master`) | ||
- [ ] Documentation reflects all relevant changes | ||
- [ ] Branch is prefixed with: `docs/`, `feat/`, `chore/`, `bugfix/` | ||
- [ ] Ensure code linting is current - run `pnpm format` | ||
- [ ] All test cases are passing - run `pnpm test` | ||
- [ ] Includes a changeset (if relevant; see above) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters