Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if moving CSS-Imports has any detrimental side effects #1286

Closed
Sarenor opened this issue Apr 5, 2023 · 4 comments
Closed

Investigate if moving CSS-Imports has any detrimental side effects #1286

Sarenor opened this issue Apr 5, 2023 · 4 comments
Labels
proposals Further information is requested

Comments

@Sarenor
Copy link
Contributor

Sarenor commented Apr 5, 2023

Describe what feature you'd like. Pseudo-code, mockups, or screenshots of similar solutions are encouraged!

We've found that Tailwind behaves differently when skeleton.css etc. are imported in app.postcss instead of the root +layout.svelte.
So far, we don't officially recommend moving the imports there since we fear unknown side effects and things not working as expected with the way Tailwind behaves.

On the other hand, potentially having layer-directives & @apply available for Skeleton & End user classes could be a very valuable enhancement so we should devote some time to investigation.

What type of pull request would this be?

Enhancement

Any links to similar examples or other references we should review?

https://discord.com/channels/1003691521280856084/1093117288875569192

@Sarenor Sarenor added the feature request Request a feature or introduce and update to the project. label Apr 5, 2023
@endigo9740 endigo9740 added proposals Further information is requested and removed feature request Request a feature or introduce and update to the project. labels Apr 6, 2023
@MLNW
Copy link
Contributor

MLNW commented Apr 7, 2023

Relates to #1152

@endigo9740
Copy link
Contributor

endigo9740 commented Apr 21, 2023

@MLNW just to make sure we're on the same page - the relation is that by moving the CSS imports into the stylesheet, that folks are free to use the automatic import reordering feature of VS code without issue. Is that correct?

If so I agree with that take. And we should weigh that with considering this change.

If we proceed forward with this let's make sure to remember to remove the new FAQ bullet point that I implemented today.

@MLNW
Copy link
Contributor

MLNW commented Apr 21, 2023

Yes, that's correct

@endigo9740
Copy link
Contributor

With the launch of v2 this is issue is no longer relevant and can be considered complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposals Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants