Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename docSell to docShell #1361

Merged
merged 1 commit into from
Apr 24, 2023
Merged

rename docSell to docShell #1361

merged 1 commit into from
Apr 24, 2023

Conversation

bartduisters
Copy link
Contributor

To have more clarity docSellDefaults was renamed to docShellDefaults. The placement swap of the imports is due to import sorting. Can be reverted if not wanted.

I do prefer automatic import sorting on projects with multiple contributors to have consistent import orders.

@vercel
Copy link

vercel bot commented Apr 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2023 1:23pm

@endigo9740
Copy link
Contributor

endigo9740 commented Apr 24, 2023

The base change is fine, but...

The placement swap of the imports is due to import sorting. Can be reverted if not wanted.
I do prefer automatic import sorting on projects with multiple contributors to have consistent import orders.

We don't support this right now. It's not a matter of preference, this causes detrimental behavior where stylesheet imports can be sorted in an incorrect order. Order matters for our stylesheet imports. We're actually adding a new FAQ (last item) that details this here:
https://dev.skeleton.dev/docs/introduction#faqs

We believe if we move our CSS imports to occur within the global stylesheet, this might avoid behavior per:
#1286

But currently this is untested. We may need to deny PRs that change import order going forward until this situation is handled. Especially for changes to the root layout. Please use discretion when utilizing the reordering please.

Generally speaking only change the item described in the PR. Anything else is out of scope and can be harder to review.

@endigo9740 endigo9740 merged commit 75a4ad8 into skeletonlabs:dev Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants