Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background hover tokens are not working as expected #1718

Closed
endigo9740 opened this issue Jul 3, 2023 · 3 comments · Fixed by #1824
Closed

Background hover tokens are not working as expected #1718

endigo9740 opened this issue Jul 3, 2023 · 3 comments · Fixed by #1824
Assignees
Labels
bug Something isn't working
Milestone

Comments

@endigo9740
Copy link
Contributor

endigo9740 commented Jul 3, 2023

Current Behavior

I've noted the .bg-hover-primary-token now shows a surface color tone. We should test secondary, tertiary, etc as well just in case. We should review how these are being inserted into the Tailwind plugin and ensure all is well.

@AdrianGonz97 pining you as an FYI.

Expected Behavior

The primary version should have a semi-transparent green tone when using the Skeleton theme. However this is coming through as a neutral surface tone instead.

Steps To Reproduce

View on any page that uses these styles, including our doc site navigation or the List element styles:
https://www.skeleton.dev/elements/lists

@endigo9740 endigo9740 added the bug Something isn't working label Jul 3, 2023
@AdrianGonz97
Copy link
Member

Went digging through our past PRs to see where the first occurrence for this came from and I think it may have been this one: #1577 which aimed to resolve this issue: #1574.

@Mahmoud-zino
Copy link
Sponsor Contributor

ops, my fault 😅, let me know if I can help correct it, and sorry for the inconvenience.

@endigo9740 endigo9740 added this to the v2.0 milestone Jul 5, 2023
@endigo9740
Copy link
Contributor Author

@Mahmoud-zino if you're looking for an issue this might be one to jump on. I believe this is still in effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants