Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/background-hover-token-color #1824

Conversation

Mahmoud-zino
Copy link
Sponsor Contributor

@Mahmoud-zino Mahmoud-zino commented Aug 5, 2023

Linked Issue

Closes #1718

Description

It seems like this is an issue known in TailwindCSS but they are not considering it as a bug🥲, see tailwindlabs/tailwindcss#10855 (comment) and tailwindlabs/tailwindcss#10855 (comment)

as a workaround, I duplicated the class with .dark in #1577 (I didn't know this was a bug in :hover) but changed the value of the color thinking it should be different, so I just updated the color value to match light mode for now.

Changsets

bugfix: Fixed .bg-hover-primary-token color in dark mode.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

@changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2023

🦋 Changeset detected

Latest commit: 89dc5c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/skeleton Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Aug 5, 2023 2:33pm

@endigo9740 endigo9740 merged commit 08685fb into skeletonlabs:dev Aug 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Background hover tokens are not working as expected
2 participants