Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeleton v2 migration to Svelte 5 #2634

Closed
endigo9740 opened this issue Apr 27, 2024 · 3 comments
Closed

Skeleton v2 migration to Svelte 5 #2634

endigo9740 opened this issue Apr 27, 2024 · 3 comments
Assignees
Labels
administration Items related to the project but outside the code.
Milestone

Comments

@endigo9740
Copy link
Contributor

endigo9740 commented Apr 27, 2024

Svelte 5 has reached Release Candidate status per today's Svelte Summit:

The Plan

As such, we will begin investigating the migration process for Skeleton v2 projects. This will start with a research phase will will start asap.

For Users

If you use Skeleton v2 and are keen to update to the Svelte 5 RC, we encourage you do so on a dedicate feature branch. We match Svelte's stance on this and DO NOT recommend you deploy to Production yet. If you encourage issues while doing this, please report them in the comments section below.

For Contributors

Likewise, please post any findings while testing the migration process here. This will be helpful in generating a dedicated Skeleton + Svelte 5 migration guide asap. Note that we will not be enabling Svelte 5 features in Skeleton v2. These should be restricted to Skeleton v3.

@endigo9740 endigo9740 added the administration Items related to the project but outside the code. label Apr 27, 2024
@endigo9740 endigo9740 added this to the v2.0 milestone Apr 27, 2024
@endigo9740 endigo9740 self-assigned this Apr 27, 2024
@endigo9740 endigo9740 pinned this issue Apr 27, 2024
@endigo9740
Copy link
Contributor Author

endigo9740 commented Apr 29, 2024

I'm happy to report that migrating from Svelte v4 -> Svelte v5 RC seems to cause no major breaking changes in small scale projects running Skeleton v2. This includes the following:

Note the only notable issues is the addition of new a11y warnings, which we'll aim to address before the next release next week:

Next up:

  • Upgrading the Skeleton v2 doc site

Note that we will not be pushing Svelte v5 RC updates to production. This will isolate to a test branch only.

I'll write a follow up post once the v2 doc site update test is complete, then set about writing the migration guide to share with everyone immediately after. ETA should be late today or tomorrow.

@endigo9740
Copy link
Contributor Author

endigo9740 commented Apr 29, 2024

I ran into a couple snags while preparing to update the Skeleton v2 doc site - we need to upgrade to Svelte v4 and SvelteKit v2 first.

So I'll pick up from here tomorrow and verify all is well for Svelte v5 RC. Then the migration guide will start immediately after!

@endigo9740
Copy link
Contributor Author

endigo9740 commented Apr 30, 2024

The guide is now available here! Find it pinned in the GitHub Discussions section:

@endigo9740 endigo9740 unpinned this issue Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
administration Items related to the project but outside the code.
Projects
None yet
Development

No branches or pull requests

1 participant