-
-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve a11y warnings in multiple components #2632
Comments
This comment was marked as resolved.
This comment was marked as resolved.
When updating to Svelte v5 RC, there appears to be a longer list of a11y warnings: Full dump:
|
Per the open PR, all known a11y warnings have been resolved with only two exceptions:
Each have structural flaws to the way the backdrop markup was constructed. This will not be trivial to resolve without a major refactor, which may be out of scope for Skeleton v2. However, please note these issues will not persist in Skeleton v3. So a solution is coming in the future. |
Current Behavior
Expected Behavior
The a11y issues causing these warnings should be addressed.
Most warnings seem to be related to missing closing tags, which is a recent change:
Steps To Reproduce
Create a Skeleton project, use any of features, the errors will appear in the terminal.
Link to Reproduction / Stackblitz
No response
More Information
We've silenced similar errors in the past, but it looks like newer versions of Svelte have implemented some additional checks.
Migration script available via:
The text was updated successfully, but these errors were encountered: