Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/migrate to new package process #1170

Merged
merged 12 commits into from
Apr 3, 2023
Merged

Feat/migrate to new package process #1170

merged 12 commits into from
Apr 3, 2023

Conversation

niktek
Copy link
Contributor

@niktek niktek commented Mar 17, 2023

What does your PR address?

Updates to package.json to match new process from SK
Added keywords to show up on npmjs.org
Adjusted pre/post build scripts to reflect new package process
Added quick fixes to A11y warnings so that people might be incentivised to actually test the package
Dependencies upgrade - have hard pinned TypeScript to 4.9.5 till it is safe to go to 5.x

Fixes #1163

@vercel
Copy link

vercel bot commented Mar 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
skeleton-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 31, 2023 at 7:41PM (UTC)

@endigo9740
Copy link
Contributor

@niktek let's discuss this during the team meeting today!

@endigo9740
Copy link
Contributor

@niktek sorry I haven't been on in the evenings as much to catch you on this, but let me know what's needed here to move this forward. If you set out a set of testing conditions I'll run through that tomorrow. Thanks!

@endigo9740
Copy link
Contributor

endigo9740 commented Mar 31, 2023

@niktek I aimed to run the package command, but was met with an error right at the end.

Screenshot 2023-03-31 at 12 37 13 PM

I'm also seeing a ton of uncommitted files after running package. It seems the contents of /package are no longer part of .gitignore?

Screenshot 2023-03-31 at 12 40 41 PM

@endigo9740
Copy link
Contributor

@niktek Both Dom and myself were able to test this and confirm things appear to be working as expected, so I'm going to go ahead and merge. That said, let's monitor this over the next couple weeks, even through release to ensure all is well with the new updates.

@endigo9740 endigo9740 merged commit 99ea3cb into skeletonlabs:dev Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update project dependencies
2 participants