-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppRail improvements #1402
AppRail improvements #1402
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@unlocomqx just a heads up I did see this come through, but I'll have to return to this later this week when I have time for a proper review. Thanks for your submission. This looks great with a quick scan! |
@endigo9740 It's cool, take your time Thank you |
@unlocomqx this seems like a great change, great job. Thanks for your contribution. I'm going to merge this now and this will be part of next week's release! |
Great news. Glad to have contributed to such awesome lib Cheers |
Before submitting the PR:
npm run test
?branch -m new-branch-name
What does your PR address?
This PR improves DX related to using
AppRail
andAppRailTile
.tag="a"
when you pass ahref
toAppRailTile
.href
will be used as thevalue
when novalue
is provided, resulting in less code repetition and simpler state management.AppRail
. Thus making it possible to pass aderived
store (to pass in current pathname for example).AppRailTile
without a storecannot read properties of undefined (reading 'set')
Code sample