Fix: Toast position incorrect type

[CheesyPhoenix]

Before submitting the PR:

• Does your PR reference an issue? If not, please chat to the team on Discord or GitHub before submission.
• Did you update and run tests before submission using npm run test?
• Does your branch follow our naming convention? If not, please amend the branch name using branch -m new-branch-name
• Did you update documentation related to your new feature or changes?: Was not required

What does your PR address?

Fixes #1403. The type of position in the Toast.svelte component was only defined through a JSDoc comment leading to TypeScript inferring the type as string. Moved this to a TypeScript type instead, so that the type is now inferred correctly leading to intellisense/autocomplete working. See issue for more details.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
skeleton-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 30, 2023 5:17pm

[Sarenor]

Thanks for the contribution!

[endigo9740]

@CheesyPhoenix you'll have to provide the type definition both to the property AND the JSDoc, as both have a purpose here. The type on the property ensures Typescript can providing IntelliSense, while the JSDoc comment automatically documents the property.

https://www.skeleton.dev/docs/contributing/documentation

If you can make this change and include both we'll merge this. Thanks!

[CheesyPhoenix]

@CheesyPhoenix you'll have to provide the type definition both to the property AND the JSDoc, as both have a purpose here. The type on the property ensures Typescript can providing IntelliSense, while the JSDoc comment automatically documents the property.

https://www.skeleton.dev/docs/contributing/documentation

If you can make this change and include both we'll merge this. Thanks!

Ah, ok. Didn't know about this. Fixed it now.

[endigo9740]

Perfect, thanks @CheesyPhoenix