Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes TS-Error on filters.test.ts #1405

Merged

Conversation

delight
Copy link
Contributor

@delight delight commented Apr 30, 2023

  • TS2769: No overload matches this call
No overload matches this call.
  Overload 1 of 2, '(component: Constructor<NoirLight__SvelteComponent_>, componentOptions?: SvelteComponentOptions<NoirLight__SvelteComponent_> | undefined, renderOptions?: Omit<...> | undefined): RenderResult<...>', gave the following error.
    Argument of type 'typeof Noir__SvelteComponent_' is not assignable to parameter of type 'SvelteComponentOptions<NoirLight__SvelteComponent_> | undefined'.
      Type 'typeof Noir__SvelteComponent_' is not assignable to type 'Record<string, never>'.
        Index signature for type 'string' is missing in type 'typeof Noir__SvelteComponent_'.
  Overload 2 of 2, '(component: Constructor<NoirLight__SvelteComponent_>, componentOptions?: SvelteComponentOptions<NoirLight__SvelteComponent_> | undefined, renderOptions?: RenderOptions<...> | undefined): RenderResult<...>', gave the following error.
    Argument of type 'typeof Noir__SvelteComponent_' is not assignable to parameter of type 'SvelteComponentOptions<NoirLight__SvelteComponent_> | undefined'.ts(2769)

Before submitting the PR:

  • Does your PR reference an issue? If not, please chat to the team on Discord or GitHub before submission.
  • [ x ] Did you update and run tests before submission using npm run test?
  • [ x ] Does your branch follow our naming convention? If not, please amend the branch name using branch -m new-branch-name
  • Did you update documentation related to your new feature or changes?

What does your PR address?

Fixes a TS error in a testfile
TS2769: No overload matches this call

- TS2769: No overload matches this call

No overload matches this call.
  Overload 1 of 2, '(component: Constructor<NoirLight__SvelteComponent_>, componentOptions?: SvelteComponentOptions<NoirLight__SvelteComponent_> | undefined, renderOptions?: Omit<...> | undefined): RenderResult<...>', gave the following error.
    Argument of type 'typeof Noir__SvelteComponent_' is not assignable to parameter of type 'SvelteComponentOptions<NoirLight__SvelteComponent_> | undefined'.
      Type 'typeof Noir__SvelteComponent_' is not assignable to type 'Record<string, never>'.
        Index signature for type 'string' is missing in type 'typeof Noir__SvelteComponent_'.
  Overload 2 of 2, '(component: Constructor<NoirLight__SvelteComponent_>, componentOptions?: SvelteComponentOptions<NoirLight__SvelteComponent_> | undefined, renderOptions?: RenderOptions<...> | undefined): RenderResult<...>', gave the following error.
    Argument of type 'typeof Noir__SvelteComponent_' is not assignable to parameter of type 'SvelteComponentOptions<NoirLight__SvelteComponent_> | undefined'.ts(2769)
@vercel
Copy link

vercel bot commented Apr 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2023 2:05pm

@endigo9740 endigo9740 merged commit 5f2689b into skeletonlabs:dev Apr 30, 2023
2 checks passed
@delight delight deleted the bugFix/TS2769-on-filters.test.ts branch July 29, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants