Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add media queries to jss #1495

Merged
merged 1 commit into from
May 15, 2023

Conversation

waynetee
Copy link
Contributor

@waynetee waynetee commented May 13, 2023

Before submitting the PR:

  • Does your PR reference an issue? If not, please chat to the team on Discord or GitHub before submission.
  • Did you update and run tests before submission using npm run test?
  • Does your branch follow our naming convention? If not, please amend the branch name using branch -m new-branch-name
  • Did you update documentation related to your new feature or changes?

What does your PR address?

Fixes skeletonlabs/create-skeleton-app#29

In development mode, we add an extra "intellisense plugin" to tailwind that redeclares our CSS. This essentially appends a new copy of our styles in the generated style sheet. However, media queries are currently not being included in this "intellisense plugin". The result is that the appended styles override the original media queries (in CSS media queries must be ordered after the base styles for them to work). The end result is that media queries will fail in development mode.

In addition to making media queries work consistently, this PR also adds the media queries to intellisense.

Before:
image

After:
image

@vercel
Copy link

vercel bot commented May 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2023 6:37pm

@waynetee waynetee marked this pull request as ready for review May 14, 2023 04:59
@endigo9740
Copy link
Contributor

@AdrianGonz97 implemented this originally so I'll kindly ask him to review this. FYI I'm usually away on weekends so it'll be Monday at the earliest before I circle back to this. Seems interesting though, thanks!

@AdrianGonz97
Copy link
Member

@waynetee This works amazingly! Thank you!

@endigo9740 endigo9740 merged commit 79b0e9a into skeletonlabs:dev May 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

H2 Size for larger screen width - Welcome Template in dev mode
3 participants