New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/tableOfContents-safeguard #1565
Chore/tableOfContents-safeguard #1565
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 0c18af1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@ryceg I'm good to merge this, but we'll need a changeset submitted and the linting is failing per the CI process. You may need top pull in the latest changes per Adrians's suggestion on Discord, then:
|
@ryceg per your pending PRs, I noted linting is failing for several of them. However, check this out locally it appears to be the issue you're working to solve in each individual PR
Given this, I'm going to go ahead and merge your PRs that now contain changesets. Then I'll aim to test again once all are in place. I'd welcome your help in resolving any remaining after this. |
Before submitting the PR:
npm run test
?branch -m new-branch-name
What does your PR address?
elemTarget
from beingscrollIntoView
'd if it is somehow not presentallowedHeadingsList
to be aNodeListOf<HTMLElement> | undefined
which is more accurate to its typing- it was being initialised as an empty array, and whileNodeList
s are able to iterate withforEach()
, they are not technically arrays (src: https://developer.mozilla.org/en-US/docs/Web/API/NodeList)