-
-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update dependencies #1648
Conversation
🦋 Changeset detectedLatest commit: 445df6e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
skeleton.dev
dependencies
@AdrianGonz97 so now that we have the library and documentation split, it may be worth reviewing which project needs which dependency. I'm guessing you and Nik just cloned the same set for both projects. However, there's some that aren't needed in both - such as Floating UI. That's really only needed in the docs for now, we don't directly access any part of this from our popups inside the package lib. |
@AdrianGonz97 @niktek I've set Nik as a reviewer on this. If he gives the thumbs up I think it's good to merge. We can dogfood this as part of this current release cycle over the next couple weeks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Description
We're a bit behind with a fair number of our dependencies, resulting in some of the security warnings that we get for the docs site. So I've gone ahead and incrementally updated everything that I can.
I also updated TS to
5.0.3
even though5.1.3
has been officially released. It seems that@typescript-eslint
needs a bit of time to catch up to the latest release, so once they do, I'll aim to update TS to the latest.Upgrading to TS 5.0 breaks
vite-plugin-sveld
since they depend onsvelte-preprocess@4.X.X
which doesn't support TS 5.0 and up. I've gone ahead and added the plugin locally so that we can control that independently.Edit: I've also gone ahead and included updating our dev deps for the
@skeletonlabs/skeleton
package as well.Changsets
Instructions: Changesets automate our changelog. If you modify files in
/package/skeleton
, runpnpm changeset
in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should beminor
while chores and bugfixes should bepatch
. Please prefix the changeset message withfeat:
,bugfix:
orchore:
.Checklist
Please read and apply all contribution requirements.
dev
branch (NEVERmaster
)docs/
,feat/
,chore/
,bugfix/
pnpm check
pnpm format
pnpm test