Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #1648

Merged
merged 10 commits into from
Jun 12, 2023
Merged

Conversation

AdrianGonz97
Copy link
Member

@AdrianGonz97 AdrianGonz97 commented Jun 7, 2023

Description

We're a bit behind with a fair number of our dependencies, resulting in some of the security warnings that we get for the docs site. So I've gone ahead and incrementally updated everything that I can.

I also updated TS to 5.0.3 even though 5.1.3 has been officially released. It seems that @typescript-eslint needs a bit of time to catch up to the latest release, so once they do, I'll aim to update TS to the latest.

Upgrading to TS 5.0 breaks vite-plugin-sveld since they depend on svelte-preprocess@4.X.X which doesn't support TS 5.0 and up. I've gone ahead and added the plugin locally so that we can control that independently.

Edit: I've also gone ahead and included updating our dev deps for the @skeletonlabs/skeleton package as well.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /package/skeleton, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2023

🦋 Changeset detected

Latest commit: 445df6e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/skeleton Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2023 9:13pm

@AdrianGonz97 AdrianGonz97 changed the title chore: update skeleton.dev dependencies chore: update dependencies Jun 7, 2023
@endigo9740
Copy link
Contributor

endigo9740 commented Jun 7, 2023

@AdrianGonz97 so now that we have the library and documentation split, it may be worth reviewing which project needs which dependency. I'm guessing you and Nik just cloned the same set for both projects. However, there's some that aren't needed in both - such as Floating UI. That's really only needed in the docs for now, we don't directly access any part of this from our popups inside the package lib.

@endigo9740
Copy link
Contributor

@AdrianGonz97 @niktek I've set Nik as a reviewer on this. If he gives the thumbs up I think it's good to merge. We can dogfood this as part of this current release cycle over the next couple weeks.

Copy link
Contributor

@niktek niktek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@endigo9740 endigo9740 merged commit e31736b into skeletonlabs:dev Jun 12, 2023
4 checks passed
@AdrianGonz97 AdrianGonz97 deleted the chore/update-deps branch June 21, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants