Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: drawer blur typo #1663

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

Mahmoud-zino
Copy link
Sponsor Contributor

@Mahmoud-zino Mahmoud-zino commented Jun 13, 2023

Linked Issue

Closes #1662

Description

'backdrop-blur-xs' -> 'backdrop-blur-sm'

Changsets

Not sure if we need a changeset for typos, If so, let me know and I will add it.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2023

🦋 Changeset detected

Latest commit: d246a60

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/skeleton Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Jun 13, 2023 3:38pm

@AdrianGonz97
Copy link
Member

@Mahmoud-zino

Not sure if we need a changeset for typos, If so, let me know and I will add it.

Since we're modifying the lib itself, a changeset is needed. Cases where we wouldn't need one would be like doc site changes or maybe fixing a typo in a comment.

@endigo9740
Copy link
Contributor

Thanks @Mahmoud-zino, we're trying to keep consistency with modals, so given neither had blur I've set this to an empty string. That'll keep consistency with prior versions. Merging this now!

@endigo9740 endigo9740 merged commit efcbd99 into skeletonlabs:dev Jun 13, 2023
2 of 3 checks passed
@Mahmoud-zino Mahmoud-zino deleted the bugfix/drawer-blur-typo branch July 5, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tailwind does not have backdrop-blur-xs
3 participants