Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: make scrollbar corner background transparent #1908

Conversation

brecht-vde
Copy link
Contributor

Linked Issue

Closes #1797

Description

Makes scrollbar corner background transparent using the ::-webkit-scrollbar-corner pseudo-element.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages/skeleton, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

@changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2023

🦋 Changeset detected

Latest commit: a3e6f32

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/tw-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Aug 21, 2023 4:29pm

@endigo9740
Copy link
Contributor

Thanks @brecht-vde. I'll aim to review this on Monday, but at quick glance all looks well. Thanks for your contribution!

@endigo9740
Copy link
Contributor

endigo9740 commented Aug 21, 2023

@brecht-vde I made a quick modification to the style - it now uses the same background token as the track versus using transparent. This provides a more aesthetically pleasing effect IMO.

Before:

Screenshot 2023-08-21 at 11 25 53 AM

After:

Screenshot 2023-08-21 at 11 25 34 AM

I've also updated the changeset to better reflect this change. I'll aim to merge this shortly and this will be part of the v2 release next week.

@brecht-vde
Copy link
Contributor Author

@brecht-vde I made a quick modification to the style - it now uses the same background token as the track versus using transparent. This provides a more aesthetically pleasing effect IMO.

You're right, looks better in this browser :).

@endigo9740 endigo9740 merged commit cbce034 into skeletonlabs:v2 Aug 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants