bugfix: allow different styles in button groups

[ak4zh]

Linked Issue

Closes #1725

Description

Allow different styles /. variants of buttons inside button groups.
Needs some more improvements, the first and last elements gets cut-off, I am playing with tailwindcss first: and last: child directive to try to get it working.

Here's how it looks currently:

Screen.Recording.2023-08-22.at.11.43.22.AM.mov

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages/skeleton, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

• This PR targets the dev branch (NEVER master)
• Documentation reflects all relevant changes
• Branch is prefixed with: docs/, feat/, chore/, bugfix/
• Ensure Svelte and Typescript linting is current - run pnpm check
• Ensure Prettier linting is current - run pnpm format
• All test cases are passing - run pnpm test
• Includes a changeset (if relevant; see above)

[changeset-bot]

⚠️ No Changeset found

Latest commit: 8d669fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
skeleton-docs	❌ Failed (Inspect)		Aug 22, 2023 7:15am

[ak4zh]

btn-group-vertical

[endigo9740]

Hey @ak4zh unfortunately I think there was some miscommunication on this issue. The poster in #1725 originally reported their issue on Discord, to which I troubleshooted and confirmed an issue was present. I ask them to file this on GitHub, but they misrepresented the issue here.

They wanted to be able to mix and match variants for the child buttons within a button group. But this is not something we would want, it would be a breaking change that was harmful to UX.

However, I followed up here, and clarified on the issue, likely culprit, and desired change:
#1725 (comment)

Which is to say, allowing users to append a variant to the children to help represent state. Such as showing of the children in an "active" state. Essentially the child variant should take precedence over the group variant. But this was not happening, likely due to the use of important per the stylesheet linked.

Furthermore, all checks have failed for your merge, which means there's some sort of inherit issue with the PR itself. Perhaps you based this off the wrong branch originally?

Either way, we cannot move forward with this. If you would like to resubmit aiming to follow my guidance in the post, then I'll be happy to review.