Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion Item ID fix #2279

Merged
merged 8 commits into from
Dec 3, 2023
Merged

Accordion Item ID fix #2279

merged 8 commits into from
Dec 3, 2023

Conversation

endigo9740
Copy link
Contributor

@endigo9740 endigo9740 commented Dec 3, 2023

Linked Issue

Closes #2265

Replaces: #2270

Description

Moves the dynamically generated ID text to be part of the default id prop value. Which means when overwritten by a custom ID, this is passed verbatim in the on:toggle forward event details.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

@endigo9740 endigo9740 linked an issue Dec 3, 2023 that may be closed by this pull request
Copy link

changeset-bot bot commented Dec 3, 2023

🦋 Changeset detected

Latest commit: f128d05

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/skeleton Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Dec 3, 2023 7:19pm

@endigo9740 endigo9740 merged commit 30d295e into dev Dec 3, 2023
4 checks passed
@endigo9740 endigo9740 deleted the bugfix/accordion-item-id branch December 3, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with setting id for AccordionItem
2 participants