Feat/progress #2556

Hugos68 · 2024-03-15T22:49:19Z

Closes: #2390

changeset-bot · 2024-03-15T22:49:23Z

⚠️ No Changeset found

Latest commit: 3d67114

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-03-15T22:49:24Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
skeleton-docs	⬜️ Ignored (Inspect)	Visit Preview		Mar 28, 2024 8:23pm
skeleton-themes	⬜️ Ignored (Inspect)	Visit Preview		Mar 28, 2024 8:23pm

vercel · 2024-03-15T22:49:25Z

@Hugos68 is attempting to deploy a commit to the Skeleton Labs Team on Vercel.

A member of the Team first needs to authorize it.

packages/skeleton-react/src/components/Progress/Progress.tsx

endigo9740 · 2024-03-19T21:18:33Z

packages/skeleton-react/src/components/Progress/Progress.tsx

+}: ProgressProps) {
+	useEffect(() => {
+		if (min > max) {
+			console.error(


FYI this does not appear to be triggering for me on either the Svelte or React components.

For Svelte I tested:

Setting value: 150 and max: 100 in the preview page $state() rune

Setting the same settings via the inputs on the page

Manually passing the values via props

Weird, using the playground and just entering any value where this condition would be true results in:

Could you confirm this is working as intended?

packages/skeleton-react/src/components/Progress/Progress.tsx

packages/skeleton-react/src/components/Progress/types.ts

packages/skeleton-react/src/components/Progress/Progress.tsx

packages/skeleton-svelte/src/lib/components/Progress/Progress.svelte

endigo9740 · 2024-03-28T20:03:01Z

@Hugos68 I've completed my review and implemented a few changes.

See all changes in the commit here:
be24ed7

Cleaned up the preview page styles (because I have OCD heh)
Removed any references to min
Setup RTL demos (I'll follow up regarding animations)
Extended Tailwind to include animate-indeterminatevia the Skeleton Tailwind plugin
Renamed meterIndeterminateAnim to meterAnimate to follow Tailwind convention

The only issue I could not resolve was why the validation error for a value that exceeds a max is not working for me. But if it's working for you I'm not going to stress about it.

I'll follow up in a moment to resolve the merge conflicts.

Out of date

Hugos68 added 2 commits March 15, 2024 19:56

Started with basic element

27c1a81

formatted and linted

3dd68b6

vercel bot had a problem deploying to Preview – skeleton-docs March 15, 2024 22:49 Failure

Hugos68 marked this pull request as draft March 15, 2024 22:49

stuffs

f1597db

vercel bot had a problem deploying to Preview – skeleton-docs March 16, 2024 11:32 Failure

Svelte progress

ddd120b

vercel bot had a problem deploying to Preview – skeleton-docs March 16, 2024 15:29 Failure

Added more examples, cleaned up component

8bb2a77

vercel bot had a problem deploying to Preview – skeleton-docs March 17, 2024 00:18 Failure

Added indeterminate customization and extra examples

d579e36

vercel bot had a problem deploying to Preview – skeleton-docs March 17, 2024 10:58 Failure

Added react version

3f075e0

vercel bot had a problem deploying to Preview – skeleton-docs March 17, 2024 11:18 Failure

Added react version

94ed744

vercel bot had a problem deploying to Preview – skeleton-docs March 17, 2024 11:42 Failure

Added keyframes to react comp

3195410

vercel bot had a problem deploying to Preview – skeleton-docs March 17, 2024 12:08 Failure

This comment was marked as resolved.

Sign in to view

Updated svelte and react component

d7fd750

vercel bot had a problem deploying to Preview – skeleton-docs March 18, 2024 17:20 Failure

Added warning for min max

a7e19ee

vercel bot had a problem deploying to Preview – skeleton-docs March 18, 2024 17:23 Failure

Sarenor reviewed Mar 19, 2024

View reviewed changes

packages/skeleton-react/src/components/Progress/Progress.tsx Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

Sarenor previously requested changes Mar 19, 2024

View reviewed changes

packages/skeleton-react/src/components/Progress/Progress.tsx Outdated Show resolved Hide resolved

packages/skeleton-react/src/components/Progress/Progress.tsx Outdated Show resolved Hide resolved

packages/skeleton-react/src/components/Progress/Progress.tsx Outdated Show resolved Hide resolved

Removed memo, formatted

8394878

vercel bot had a problem deploying to Preview – skeleton-docs March 19, 2024 21:02 Failure

This comment was marked as resolved.

Sign in to view

endigo9740 requested changes Mar 19, 2024

View reviewed changes

TW forms added to React package

550b397

vercel bot had a problem deploying to Preview – skeleton-docs March 19, 2024 21:42 Failure

Removed min

7795ea2

vercel bot had a problem deploying to Preview – skeleton-docs March 20, 2024 10:36 Failure

This comment was marked as resolved.

Sign in to view

Changed anim classes description

36ba289

vercel bot had a problem deploying to Preview – skeleton-docs March 27, 2024 14:15 Failure

Updated react types description

57f1a55

vercel bot had a problem deploying to Preview – skeleton-docs March 27, 2024 14:16 Failure

Merge branch 'next' into feat/progress

60d8f4a

vercel bot had a problem deploying to Preview – skeleton-docs March 27, 2024 14:22 Failure

Hugos68 added 2 commits March 27, 2024 15:23

Merge branch 'next' into feat/progress

131677b

Resolved merge conflict

191a7af

vercel bot deployed to Preview – skeleton-themes March 28, 2024 00:22 View deployment

PR review and changes

be24ed7

vercel bot had a problem deploying to Preview – skeleton-docs March 28, 2024 20:01 Failure

Merge branch 'next' into feat/progress

1bf7d2c

endigo9740 marked this pull request as ready for review March 28, 2024 20:21

Regenerate package lock

3d67114

endigo9740 self-requested a review March 28, 2024 20:24

endigo9740 approved these changes Mar 28, 2024

View reviewed changes

endigo9740 requested a review from Sarenor March 28, 2024 20:25

vercel bot deployed to Preview – skeleton-next March 28, 2024 20:25 View deployment

endigo9740 merged commit 007f848 into skeletonlabs:next Mar 28, 2024
4 checks passed

endigo9740 mentioned this pull request Mar 28, 2024

NEXT: Astro Documentation Site #2353

Open

36 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/progress #2556

Feat/progress #2556

Hugos68 commented Mar 15, 2024 •

edited

changeset-bot bot commented Mar 15, 2024 •

edited

vercel bot commented Mar 15, 2024 •

edited

vercel bot commented Mar 15, 2024

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

endigo9740 Mar 19, 2024

Hugos68 Mar 20, 2024

Hugos68 Mar 27, 2024

This comment was marked as resolved.

endigo9740 commented Mar 28, 2024 •

edited

Feat/progress #2556

Feat/progress #2556

Conversation

Hugos68 commented Mar 15, 2024 • edited

changeset-bot bot commented Mar 15, 2024 • edited

⚠️ No Changeset found

vercel bot commented Mar 15, 2024 • edited

vercel bot commented Mar 15, 2024

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

endigo9740 Mar 19, 2024

Choose a reason for hiding this comment

Hugos68 Mar 20, 2024

Choose a reason for hiding this comment

Hugos68 Mar 27, 2024

Choose a reason for hiding this comment

This comment was marked as resolved.

endigo9740 commented Mar 28, 2024 • edited

Hugos68 commented Mar 15, 2024 •

edited

changeset-bot bot commented Mar 15, 2024 •

edited

vercel bot commented Mar 15, 2024 •

edited

endigo9740 commented Mar 28, 2024 •

edited