Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skeleton-react package cleanup #2672

Merged
merged 12 commits into from
May 18, 2024
Merged

Conversation

AdrianGonz97
Copy link
Member

@AdrianGonz97 AdrianGonz97 commented May 17, 2024

Description

This PR contains a number of changes in preparation of distributing the package:

  • Moved all of the src/components and src/utils into the lib folder. This better matches what we're doing in skeleton-svelte as well as being easier to parse what's being exported
  • Added a ./schemas export path such that schemas are now imported via @skeletonlabs/skeleton-react/schemas (will only be available in dev). This was done to prevent the schemas from being included in the distributed package
  • Added file extensions to import paths in cases where it was missing or using the wrong extension (e.g. .tsx). I also adjusted the tsconfig.json to prevent the latter in the future
  • Other miscellaneous things to make life simpler:
    • you can now start the dev server from the root with pnpm dev
    • added a watch script for the react package so that it rebuilds on changes
    • in dev, the react package should now be exporting from the dist, which should better reflect the experience of consumers when we're using it in next.skeleton.dev

we also really need to setup prettier for the react package too 😄

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skeleton-next 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 17, 2024 11:23pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
skeleton-docs ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 11:23pm
skeleton-themes ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 11:23pm

Copy link

changeset-bot bot commented May 17, 2024

⚠️ No Changeset found

Latest commit: 830377a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@AdrianGonz97 AdrianGonz97 merged commit 79415cc into next May 18, 2024
4 checks passed
@AdrianGonz97 AdrianGonz97 deleted the chore/cleanup-packaging branch May 18, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant