Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Lazy load vercel analytics #984

Merged
merged 1 commit into from
Feb 19, 2023
Merged

Fix: Lazy load vercel analytics #984

merged 1 commit into from
Feb 19, 2023

Conversation

AdrianGonz97
Copy link
Member

@AdrianGonz97 AdrianGonz97 commented Feb 19, 2023

Before submitting the PR:

  • Does your PR reference an issue? If not, please chat to the team on Discord or GitHub before submission.
  • Did you update and run tests before submission using npm run test?
  • Does your branch follow our naming convention? If not, please amend the branch name using branch -m new-branch-name
  • Did you update documentation related to your new feature or changes?

What does your PR address?

We need to lazy load the analytics to prevent the errors we've seen in dev due to ad blockers:

GET http://localhost:5173/node_modules/.vite/deps/@vercel_analytics.js?v=73c2f3ed net::ERR_BLOCKED_BY_CLIENT
manifest.js:145 TypeError: Failed to fetch dynamically imported module: http://localhost:5173/.svelte-kit/generated/client/nodes/0.js
handleError @ manifest.js:145
handle_error @ client.js?v=73c2f3ed:1812
_hydrate @ client.js?v=73c2f3ed:1749
await in _hydrate (async)
start @ start.js:33
(anonymous) @ (index):7441
localhost/:1 Uncaught (in promise) TypeError: Failed to fetch dynamically imported module: http://localhost:5173/.svelte-kit/generated/client/nodes/0.js
start.js:39 Uncaught (in promise) TypeError: Failed to fetch dynamically imported module: http://localhost:5173/.svelte-kit/generated/client/nodes/0.js

@vercel
Copy link

vercel bot commented Feb 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
skeleton-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 19, 2023 at 0:13AM (UTC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants