Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get vocab from tokenizer is better. #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FFengIll
Copy link

Some model may not provide vocab.txt and
tokenizer must work well after parse the tokenizer.json (and rebuild the vocab internal).

So we can just load vocab from tokenizer with a re-sort.

@@ -22,8 +22,6 @@
with open(dir_model + "/config.json", "r", encoding="utf-8") as f:
hparams = json.load(f)

with open(dir_model + "/vocab.txt", "r", encoding="utf-8") as f:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vocab.txt may not exist.

vocab_list = []

# print(tokenizer.get_vocab())
vocab = tokenizer.get_vocab()
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tokenizer has a good implement to get vocab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant