h265

[skeskinen]

HEVC smart cutting seems really tricky to get right. Couple times I had the feeling it's pretty much working and then it broke again.

Might have to just do a fallback to either cut on keyframes or recoding the whole thing. I'd love not doing that, since it's a little confusing for the end users.

Just know that h265 cutting can work, and I'm interested in debugging cases where it doesn't. But the official disclaimer is that it can fail and you shouldn't be surprised when it does.

[skeskinen]

Commit 50796ec introduces my own implementation of concat muxing. It seems to have fixed some of the remaining issues with hevc.

Probably because afaict ffmpeg concat format doesn't use hevc_mp4toannexb (here: https://github.com/FFmpeg/FFmpeg/blob/376b3d53c54791c1be58709df4303ba2b90851bc/libavformat/concatdec.c#L216).
And I do it here:

transcribing-video-cutter/transcribing_video_cutter/smartcut.py

Line 494 in 50796ec

remux_bitstream_filter = av.bitstream.BitStreamFilterContext('hevc_mp4toannexb', v_stream, out_stream)