Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return undefined when there is no documents #459

Merged
merged 1 commit into from Apr 12, 2019

Conversation

mathieudutour
Copy link
Contributor

fix #457

Babel would tranform [nativeDocument] = NSApplication.sharedApplication().orderedDocuments() thinking that it's a proper array but it's not, it's an NSArray so it would throw an error.

@bohemian-coding-danger
Copy link
Collaborator

Warnings
⚠️

Changes were made to package.json, but not to package-lock.json - Perhaps you need to run npm run install?

⚠️

Source/dom/models/Document.js changed, but not:

  • 📚 its docs
  • 🧪 its tests

That's OK as long as you're refactoring.

Generated by 🚫 dangerJS

@mathieudutour mathieudutour merged commit 6d29761 into develop Apr 12, 2019
@mathieudutour mathieudutour deleted the f/fix-when-no-documents branch April 12, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled Data functionality
4 participants