Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump assistant packages #17

Merged
merged 9 commits into from
Jun 8, 2021
Merged

Bump assistant packages #17

merged 9 commits into from
Jun 8, 2021

Conversation

bomberstudios
Copy link
Contributor

No description provided.

@bomberstudios
Copy link
Contributor Author

Turns out npm run package-tarball does not work in this branch. Moving to Draft status until I get this working

@bomberstudios bomberstudios marked this pull request as draft May 20, 2021 18:00
@bomberstudios bomberstudios removed the request for review from christianklotz May 20, 2021 18:00
@bomberstudios bomberstudios marked this pull request as ready for review June 2, 2021 15:45
@bomberstudios
Copy link
Contributor Author

Finally everything is working and this is ready for review

christianklotz
christianklotz requested changes Jun 3, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.nvmrc Show resolved Hide resolved
christianklotz
christianklotz reviewed Jun 3, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
christianklotz
christianklotz reviewed Jun 4, 2021
View reviewed changes
Copy link
Contributor

@christianklotz christianklotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once the @sketch-hq/sketch-file issue is resolved, good to go.

package.json Outdated Show resolved Hide resolved
@bomberstudios
Copy link
Contributor Author

Pending changes on sketch-assistants on sketch-hq/sketch-assistants#185

christianklotz
christianklotz reviewed Jun 4, 2021
View reviewed changes
Copy link
Contributor

@christianklotz christianklotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there 馃槆

package.json Outdated Show resolved Hide resolved
@bomberstudios @christianklotz
Update package.json
499e90e 
Co-authored-by: Christian Klotz <hello@christianklotz.co.uk>
@christianklotz christianklotz merged commit f1b3d56 into main Jun 8, 2021
@christianklotz christianklotz deleted the chore/bump-assistant-packages branch June 8, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianklotz christianklotz christianklotz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bomberstudios @christianklotz