Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npm publish #115

Merged
merged 13 commits into from
Nov 15, 2020
Merged

Npm publish #115

merged 13 commits into from
Nov 15, 2020

Conversation

Mxchaeltrxn
Copy link
Member

Addresses #100.

I have done everything in #100 except fixing the build badge—there doesn't seem to be an easy way to get this working so I just wanted to confirm if this is the approach you wanted to take. I'm asking because I've never done it this way before and it seems somewhat involved.

As for the rest of the tasks, everything went well though for the npm publish, I thought I didn't publish v0.1.0-0 correctly so I deleted it and republished. However, I could not republish it as v0.1.0-0 so I published it as 0.2.0-0 (in retrospect, maybe it should have been 0.1.0-1). I don't think it's a huge deal since it's dev but it's just slightly ugly/strange, I guess.

Also, I ran npm run release --tag=dev because yarn release --tag=dev did not work for me.

I was going to post an image of the folder structure after installing it as a package but you've already tried!

@vercel
Copy link

vercel bot commented Nov 13, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sketchbook-js/sketchbook/jkzndhb36
✅ Preview: https://sketchbook-git-npmpublish.sketchbook-js.vercel.app

@haydn
Copy link
Member

haydn commented Nov 13, 2020

@Mxchaeltrxn Sorry, I should have been clearer. The badge is the TravisCI badge that appears in the README:

image

Says "build unknown" at the moment cause it's not pointing to the updated repo (https://travis-ci.org/github/sketchbook-js/sketchbook).

@haydn haydn linked an issue Nov 13, 2020 that may be closed by this pull request
14 tasks
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@Mxchaeltrxn
Copy link
Member Author

Sorry that was clumsy of me. I've fixed it with a few pushes. Sorry I wasted some build minutes. I don't think I can cancel the builds because I don't have access.

Anyway, I'm not sure why the build still shows up as cancelled. It worked when I used the travis url but I used shields simply because you did.

@haydn
Copy link
Member

haydn commented Nov 14, 2020

@Mxchaeltrxn I think that main Travis CI check wasn't passing because the branch wasn't up-to-date with master. Just updated it now.

@haydn
Copy link
Member

haydn commented Nov 14, 2020

@Mxchaeltrxn Well that wasn't the reason, but I've removed that extra Travis CI check from the branch protection rules and made the pr and push checks required instead. I'm guessing Travis CI changed how the integration works at some point and moving across to a new repo has surfaced it. 🤷

@Mxchaeltrxn
Copy link
Member Author

@haydn I've done the last checkbox in issue #100!

@haydn haydn merged commit 40a918b into master Nov 15, 2020
@haydn haydn deleted the npmPublish branch November 15, 2020 00:15
@haydn
Copy link
Member

haydn commented Nov 15, 2020

@Mxchaeltrxn Merged!

I tested publishing another version on master after merging, great success:

https://unpkg.com/@sketchbook-js/sketchbook@0.2.0-1/

You probably encountered this too, there's an issue with np at the moment that incorrectly warns about new files being added:

sindresorhus/np#577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Sketchbook.js to it's own team and setup publishing process
2 participants