-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Npm publish #115
Npm publish #115
Conversation
Fix package json Fix package json v0.1.0-0
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sketchbook-js/sketchbook/jkzndhb36 |
@Mxchaeltrxn Sorry, I should have been clearer. The badge is the TravisCI badge that appears in the README: Says "build unknown" at the moment cause it's not pointing to the updated repo (https://travis-ci.org/github/sketchbook-js/sketchbook). |
7314d29
to
c142eeb
Compare
c142eeb
to
d9cb21c
Compare
d9cb21c
to
a641559
Compare
a641559
to
6174a16
Compare
6174a16
to
b704203
Compare
b704203
to
5365b52
Compare
Sorry that was clumsy of me. I've fixed it with a few pushes. Sorry I wasted some build minutes. I don't think I can cancel the builds because I don't have access. Anyway, I'm not sure why the build still shows up as cancelled. It worked when I used the travis url but I used shields simply because you did. |
@Mxchaeltrxn I think that main Travis CI check wasn't passing because the branch wasn't up-to-date with master. Just updated it now. |
@Mxchaeltrxn Well that wasn't the reason, but I've removed that extra Travis CI check from the branch protection rules and made the |
@Mxchaeltrxn Merged! I tested publishing another version on master after merging, great success: https://unpkg.com/@sketchbook-js/sketchbook@0.2.0-1/ You probably encountered this too, there's an issue with |
Addresses #100.
I have done everything in #100 except fixing the build badge—there doesn't seem to be an easy way to get this working so I just wanted to confirm if this is the approach you wanted to take. I'm asking because I've never done it this way before and it seems somewhat involved.
As for the rest of the tasks, everything went well though for the npm publish, I thought I didn't publish v0.1.0-0 correctly so I deleted it and republished. However, I could not republish it as v0.1.0-0 so I published it as 0.2.0-0 (in retrospect, maybe it should have been 0.1.0-1). I don't think it's a huge deal since it's dev but it's just slightly ugly/strange, I guess.
Also, I ran
npm run release --tag=dev
becauseyarn release --tag=dev
did not work for me.I was going to post an image of the folder structure after installing it as a package but you've already tried!