Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The 'new character' form allows you to proceed with an invalid character #46

Closed
Morgul opened this issue May 4, 2020 · 2 comments · Fixed by #114
Closed

The 'new character' form allows you to proceed with an invalid character #46

Morgul opened this issue May 4, 2020 · 2 comments · Fixed by #114
Labels
bug core Related to the core code of RPGKeeper good first issue A good issue for a new developer to tackle. papercut
Milestone
v3.0.0

Comments

@Morgul
Copy link
Member

Morgul commented May 4, 2020

Per #44:

Clearly the form shouldn't let you proceed if you don't put in the required fields. I skipped over form validation when I converted to bootstrap-vue since I was lazy. That totally needs to be added, jeeze.

At a bare minimum, the form shouldn't let you proceed. But there should also be real validation on it.
@Morgul Morgul added bug help wanted The developers would like for a community member to contribute this fix. papercut ready labels May 4, 2020
@Morgul Morgul removed the ready label Jun 28, 2020
@Morgul Morgul added this to the v3.0.0 milestone Feb 20, 2021
@Morgul Morgul added feedback requested This item needs a developer's attention and removed help wanted The developers would like for a community member to contribute this fix. labels Mar 14, 2021
@Morgul
Copy link
Member Author

Morgul commented Mar 14, 2021

So, what this really needs, is a decision about form validation. Once a validation library is picked, this becomes pretty trivial.

@Morgul
Copy link
Member Author

Morgul commented Mar 15, 2021

We're going to use: https://vuelidate.js.org/

@Morgul Morgul added core Related to the core code of RPGKeeper good first issue A good issue for a new developer to tackle. and removed feedback requested This item needs a developer's attention labels Mar 15, 2021
@Morgul Morgul mentioned this issue Mar 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug core Related to the core code of RPGKeeper good first issue A good issue for a new developer to tackle. papercut
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

Added Validation SkewedAspect/rpgkeeper
1 participant
@Morgul