Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1 add state to report #2

Merged
merged 4 commits into from
Jun 20, 2016
Merged

Conversation

vinnymac
Copy link
Contributor

No description provided.

@skiano
Copy link
Owner

skiano commented Jun 20, 2016

Is it possible for you to add a unit test in __tests__/? I probably wont get around to adding a test soon, and I think we shouldn't merge this without a test of the feature.

@vinnymac
Copy link
Contributor Author

I plan on adding tests. I agree do not merge this yet. Figured I would just start this since it has been a month since any discussion has occurred. I happen to have the bandwidth to work on it.

@skiano
Copy link
Owner

skiano commented Jun 20, 2016

terrific! thank you so much :)

@vinnymac
Copy link
Contributor Author

I modified the existing ones you had where you were tweaking the props, but I also tweaked the state where possible and expect that change. Where it wasn't possible state can't be updated because of the failed render, so I refer to the initial state in those cases. If you'd like something changed or added let me know.

@skiano skiano merged commit 16288b0 into skiano:master Jun 20, 2016
@skiano
Copy link
Owner

skiano commented Jun 20, 2016

great!

@skiano
Copy link
Owner

skiano commented Jun 20, 2016

I just released it as version 2.0.0 in NPM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants