semantic search urls #29
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eggheadio/egghead-io-nextjs/792adst78 |
| return slug.split('+').map(decodeURIComponent).join(' ') | ||
| } | ||
|
|
||
| export const createUrl = (searchState) => { |
There was a problem hiding this comment.
all of this gets a little gross, but it has tests ;)
src/pages/search/[[...all]].tsx
Outdated
| router.push(href, href, { | ||
| shallow: true, | ||
| }) | ||
| // router.push(href, href, { |
There was a problem hiding this comment.
killed this for testing purposes
|
My suggestion is to kill all the slashes and use a different delimiter. The goal is just and English phrase slugified |
|
My suggestion is to kill all the slashes and use a different delimiter. The goal is just an English phrase slugified |
|
@jaredpalmer I used Is that any better? we've got |
|
actually I like |
|
The closer to English the better. react-and-amplify |
| return ( | ||
| <div> | ||
| <NextSeo noindex={!isEmpty(searchState.query)} title={pageTitle} /> |
There was a problem hiding this comment.
if the user has typed in a query we don't want to index anything. We only index when they have applied certain refinements and no query.
joelhooks
changed the title
This is exploring some of the ideas around "semantic URLs" for site search that are friendly to google.
Basically taking the URL and parsing into Algolia params and then back again.